Introduce a setConnected method to manually set a connected flag

[zugaldia]

Currently, the PR only covers the usecase where an app handles its connectivity state internally and bypasses ConnectivityManager.

Fixes #6617.

/cc: @danswick @mapbox/android

[mention-bot]

@zugaldia, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bleege, @cammace and @tobrun to be potential reviewers.

[zugaldia]

For testing purposes, a new SNAPSHOT build has been triggered via https://www.bitrise.io/build/a66f375f4c7a5408 and it's now available in mapbox-android-sdk-4.2.0-20161006.204020-83.aar.

[ivovandongen]

@zugaldia This covers the HTTPRequest case, but not the core connectivity. The receiver that is started here will still inform the core about connectivity, through NativeConnectivityListener

I should've consolidated both right away, bit of a mess.

[zugaldia]

This covers the HTTPRequest case, but not the core connectivity. The receiver that is started here will still inform the core about connectivity, through NativeConnectivityListener

Yes. Let's not merge this PR until we take care of the ConnectivityReceiver too (maybe instead of exposing a setConnected method, we can just simply have another constructor for MapboxAccountManager where start(Context context, String accessToken) accepts a flag?).

[ivovandongen]

maybe instead of exposing a setConnected method, we can just simply have another constructor for MapboxAccountManager where start(Context context, String accessToken) accepts a flag

Definitely. It will resume less quickly probably and needs some testing to be sure. But this is by far the easiest way for now.

[zugaldia]

@ivovandongen Thinking about it, the problem with the constructor approach is that it can only be set once, and if the app connectivity state changes, there's no way to inform MapboxAccountManager of the update. I've added a quick check inside ConnectivityReceiver which helps with the original issue in OP. This still has good room for refactoring before merging.

[zugaldia]

Updated build happened via https://www.bitrise.io/build/5a1b3138c006b2e2 and it's now available here: mapbox-android-sdk-4.2.0-20161007.193849-85.aar.

[zugaldia]

The previous snapshot was accidentally built from the wrong branch (master), a correct build happened via https://www.bitrise.io/build/337c5e7fdb9d04a7 and it's now available here: mapbox-android-sdk-4.2.0-20161010.174709-89.aar.