This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Qt macOS fixes #6804
Merged
Qt macOS fixes #6804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brunoabinader, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tmpsantos, @kkaefer and @springmeyer to be potential reviewers. |
This was referenced Oct 24, 2016
brunoabinader
force-pushed
the
qt-fixes
branch
from
2d908c8
to
7f42923
Compare
kkaefer
reviewed
Oct 24, 2016
| // See https://bugreports.qt.io/browse/QTBUG-36802 for details. | ||
| static bool first = true; | ||
| if (!first) m_map.render(); | ||
| first = false; |
There was a problem hiding this comment.
I'm not sure I understand this fix. Can you explain?
There was a problem hiding this comment.
There is a bug in older versions of Qt for macOS - the first call to paintGL() for the QGLWidget shows an invalid frame buffer (status 33305), which is caught up by our GL sanity check here. After the first paintGL() call, there is a paintEvent() that internally enforces the window to be shown, and it seems only after that point the GL context seems to be usable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR:
Fixes #6794.