Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

fixes #6688: assert remaining map view notification responses are main thread #7838

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

incanus
Copy link
Contributor

@incanus incanus commented Jan 24, 2017

sign-colors

@incanus incanus added iOS Mapbox Maps SDK for iOS performance Speed, stability, CPU usage, memory usage, or power usage labels Jan 24, 2017
@incanus incanus added this to the ios-v3.4.1 milestone Jan 24, 2017
@incanus incanus self-assigned this Jan 24, 2017
@mention-bot
Copy link

@incanus, thanks for your PR! By analyzing this pull request, we identified @1ec5, @boundsj and @friedbunny to be potential reviewers.

@incanus
Copy link
Contributor Author

incanus commented Jan 25, 2017

Can't get Android tests to pass, but they should not be impacted by this change.

@1ec5
Copy link
Contributor

1ec5 commented Jan 25, 2017

Download https://jcenter.bintray.com/com/android/tools/annotations/25.2.2/annotations-25.2.2.jar
File /root/.android/repositories.cfg could not be loaded.

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':MapboxGLAndroidSDK'.
> Failed to notify project evaluation listener.
   > You have not accepted the license agreements of the following SDK components:
     [Android SDK Build-Tools 25].
     Before building your project, you need to accept the license agreements and complete the installation of the missing components using the Android Studio SDK Manager.
     Alternatively, to learn how to transfer the license agreements from one workstation to another, go to http://d.android.com/r/studio-ui/export-licenses.html
   > You have not accepted the license agreements of the following SDK components:
     [Android SDK Build-Tools 25].
     Before building your project, you need to accept the license agreements and complete the installation of the missing components using the Android Studio SDK Manager.
     Alternatively, to learn how to transfer the license agreements from one workstation to another, go to http://d.android.com/r/studio-ui/export-licenses.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

@tobrun
Copy link
Member

tobrun commented Jan 25, 2017

@incanus @1ec5 haven't pinpointed concretely where ios-memory-thread branches away from master but was able to scroll back over a month. Rebasing will solve this issue as it would include the fix in #7729.

@1ec5
Copy link
Contributor

1ec5 commented Jan 25, 2017

Apparently @incanus branched off aeba7cc. That’s pretty ancient.

@incanus
Copy link
Contributor Author

incanus commented Jan 25, 2017

Oh weird! I thought I branched off of release-ios-v3.4.0. Let me adjust the PR.

@incanus incanus changed the base branch from master to release-ios-v3.4.0 January 25, 2017 20:23
@incanus
Copy link
Contributor Author

incanus commented Jan 25, 2017

Ok, now the base is the release branch and I rebased atop it just for good measure. 🤞 for tests again.

@incanus incanus merged commit 5dc8390 into release-ios-v3.4.0 Jan 25, 2017
@incanus incanus deleted the ios-memory-thread branch January 25, 2017 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants