This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] - add accessibility support to the Android SDK #8230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugaldia
approved these changes
Mar 1, 2017
…content descriptions on Views overlain on the map.
tobrun
force-pushed
the
4857-accessibility-support
branch
from
7c9d8a6
to
e6f497c
Compare
1ec5
added
the
accessibility
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimises accessibility support for TalkBack by applying content description to all overlain View elements and removing
setClickable(true)andsetLongClickable(true)(these flags introduced some additional talkback responses while the map also works correctly without).I have been looking into using an AccesibilityDelegate but it seems that they only support a limited amount of gestures. (click, longclick) and it's not possible to add custom ones. To work around this I added
mapbox_mapActionDescriptionwhich has a similar structure as the one generated by AccessibilityDelegateCompat.