This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Enable one-finger quick-zoom gesture on iPad #8379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
added
feature
Google Maps parity
|
@friedbunny, thanks for your PR! By analyzing this pull request, we identified @incanus, @boundsj and @1ec5 to be potential reviewers. |
jmkiley
approved these changes
Mar 13, 2017
1ec5
approved these changes
Mar 13, 2017
This is probably true — one-handed iPad’ing can’t be a common use case (right?). I occasionally find myself using quick zoom in other situations, though, such as in smaller map views or when I don’t want my pinch-gesturing hand to obscure the screen/view. |
friedbunny
force-pushed
the
fb-quick-zoom-ipad
branch
from
71a8dc6
to
48e1772
Compare
|
Agree with adding this with same caveat in #8379 (review). But if the Goog does it, 👍. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the one-finger quick-zoom gesture on iPad. We had been specifically limiting this gesture to the iPhone, but it makes sense to consistently offer this gesture on all iOS devices (as Google does).
/cc @jmkiley