This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Polygon holes signature refactor #8722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
added
Android
tobrun
reviewed
Apr 12, 2017
| @@ -12,7 +12,7 @@ | |||
| /** | |||
| * Encapsulates a {@link List} of {@link LatLng} points defining a hole | |||
| */ | |||
| public class Hole extends ArrayList<LatLng> implements Parcelable { | |||
| class Hole extends ArrayList<LatLng> implements Parcelable { | |||
There was a problem hiding this comment.
since we are removing Hole.java from public API, is there a benefit of keeping this class around?
There was a problem hiding this comment.
Didn't find a way to create a Parcelable of List<List<LatLng>>.
Do you know how?
There was a problem hiding this comment.
If the outermost class is parcelable it can take care of all it's members. No need for a separate class for the holes in that case. Just move the logic over to Polygon.
There was a problem hiding this comment.
It seems
List<List<LatLng>> holes = new ArrayList<>();
in.readList(holes, LatLng.class.getClassLoader());
does the trick. Fixed it 😉
Guardiola31337
force-pushed
the
pg-7397-android-polygon-holes
branch
from
b1a4478
to
20a5bc7
Compare
Guardiola31337
force-pushed
the
pg-7397-android-polygon-holes
branch
from
20a5bc7
to
b6c914e
Compare
tobrun
approved these changes
Apr 12, 2017
This was referenced May 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored signature from
HoletoList<LatLng>.👀 @tobrun @ivovandongen