Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios, macos] Bumped Xcode version requirement to 8.0 #8775

Merged
merged 5 commits into from
Apr 25, 2017
Merged

[ios, macos] Bumped Xcode version requirement to 8.0 #8775

merged 5 commits into from
Apr 25, 2017

Conversation

jmkiley
Copy link
Contributor

@jmkiley jmkiley commented Apr 20, 2017

v3.5.2 does not seem to be compatible with Xcode 7.3.1 and crashes. Bumping the Xcode version requirement to 8.0.

cc @mapbox/ios

@jmkiley jmkiley added this to the ios-v3.6.0 milestone Apr 20, 2017
@jmkiley jmkiley self-assigned this Apr 20, 2017
@jmkiley jmkiley requested review from friedbunny and 1ec5 April 20, 2017 00:36
@friedbunny friedbunny added build iOS Mapbox Maps SDK for iOS labels Apr 20, 2017
1ec5
1ec5 approved these changes Apr 20, 2017
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will allow us to start introducing class properties (and deprecating some class methods potentially).

For the sake of future searching, was the compiler crashing, or was Xcode itself crashing? What did the crash trace look like?

platform/ios/CHANGELOG.md Outdated
@@ -18,6 +18,7 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT
* The error passed into `-[MGLMapViewDelegate mapViewDidFailLoadingMap:withError:]` now includes a more specific description and failure reason. ([#8418](https://github.com/mapbox/mapbox-gl-native/pull/8418))
* Fixed an issue where gesture recognizers associated with map view interactivity were not disabled when their related interactions were disabled. ([#8304](https://github.com/mapbox/mapbox-gl-native/pull/8304))
* Fixed an issue where re-adding a layer that had been previously removed from a style would reset its paint properties. Moved initializers for `MGLTileSource`, `MGLStyleLayer`, and `MGLForegroundStyleLayer` to their concrete subclasses; because these classes were already intended for initialization only via concrete subclasses, this should have no developer impact. ([#8626](https://github.com/mapbox/mapbox-gl-native/pull/8626))
* Xcode 8.0 or higher is now required to use this SDK.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is important enough that we should make it the first item for the release.

@friedbunny
Copy link
Contributor

friedbunny commented Apr 20, 2017 •
edited
Loading

The crash while using Xcode 7.3.1 with v3.5.2 occurs while loading dylibs in the simulator:

* thread #1: tid = 0x2c5239, 0x000000010a9162fe dyld_sim`memcmp + 9, stop reason = EXC_BAD_ACCESS (code=50, address=0x10a981000)
  * frame #0: 0x000000010a9162fe dyld_sim`memcmp + 9
    frame #1: 0x000000010a90a33b dyld_sim`ImageLoaderMachO::validateFirstPages(linkedit_data_command const*, int, unsigned char const*, unsigned long, long long, ImageLoader::LinkContext const&) + 121
    frame #2: 0x000000010a90cee2 dyld_sim`ImageLoaderMachOCompressed::instantiateFromFile(char const*, int, unsigned char const*, unsigned long, unsigned long long, unsigned long long, stat const&, unsigned int, unsigned int, linkedit_data_command const*, encryption_info_command const*, ImageLoader::LinkContext const&) + 290
    frame #3: 0x000000010a909643 dyld_sim`ImageLoaderMachO::instantiateFromFile(char const*, int, unsigned char const*, unsigned long long, unsigned long long, stat const&, ImageLoader::LinkContext const&) + 327
    frame #4: 0x000000010a8fde8d dyld_sim`dyld::loadPhase6(int, stat const&, char const*, dyld::LoadContext const&) + 456
    frame #5: 0x000000010a9014f1 dyld_sim`dyld::loadPhase5(char const*, char const*, dyld::LoadContext const&, std::__1::vector<char const*, std::__1::allocator<char const*> >*) + 599
    frame #6: 0x000000010a901280 dyld_sim`dyld::loadPhase4(char const*, char const*, dyld::LoadContext const&, std::__1::vector<char const*, std::__1::allocator<char const*> >*) + 180
    frame #7: 0x000000010a900c95 dyld_sim`dyld::loadPhase3(char const*, char const*, dyld::LoadContext const&, std::__1::vector<char const*, std::__1::allocator<char const*> >*) + 762
    frame #8: 0x000000010a90074c dyld_sim`dyld::loadPhase1(char const*, char const*, dyld::LoadContext const&, std::__1::vector<char const*, std::__1::allocator<char const*> >*) + 135
    frame #9: 0x000000010a8fdc9a dyld_sim`dyld::loadPhase0(char const*, char const*, dyld::LoadContext const&, std::__1::vector<char const*, std::__1::allocator<char const*> >*) + 213
    frame #10: 0x000000010a8fda28 dyld_sim`dyld::load(char const*, dyld::LoadContext const&) + 179
    frame #11: 0x000000010a901623 dyld_sim`dyld::libraryLocator(char const*, bool, char const*, ImageLoader::RPathChain const*) + 52
    frame #12: 0x000000010a906ee0 dyld_sim`ImageLoader::recursiveLoadLibraries(ImageLoader::LinkContext const&, bool, ImageLoader::RPathChain const&, char const*) + 270
    frame #13: 0x000000010a906458 dyld_sim`ImageLoader::link(ImageLoader::LinkContext const&, bool, bool, bool, ImageLoader::RPathChain const&) + 92
    frame #14: 0x000000010a8fef01 dyld_sim`dyld::link(ImageLoader*, bool, bool, ImageLoader::RPathChain const&) + 149
    frame #15: 0x000000010a8fff05 dyld_sim`dyld::_main(macho_header const*, unsigned long, int, char const**, char const**, char const**, unsigned long*) + 2809
    frame #16: 0x000000010a8fc251 dyld_sim`start_sim + 136
    frame #17: 0x0000000110499510 dyld`dyld::useSimulatorDyld(int, macho_header const*, char const*, int, char const**, char const**, char const**, unsigned long*, unsigned long*) + 2246
    frame #18: 0x0000000110497a39 dyld`dyld::_main(macho_header const*, unsigned long, int, char const**, char const**, char const**, unsigned long*) + 241
    frame #19: 0x0000000110493249 dyld`dyldbootstrap::start(macho_header const*, int, char const**, long, macho_header const*, unsigned long*) + 470
    frame #20: 0x0000000110493036 dyld`_dyld_start + 54

@1ec5
Copy link
Contributor

1ec5 commented Apr 20, 2017

Previously #6842 (comment).

@friedbunny
Copy link
Contributor

Confirmed that Xcode 8.0 still works.

@jmkiley
Copy link
Contributor Author

jmkiley commented Apr 20, 2017

Confirmed that the -symbols build worked with Xcode 7.3.1. I will revise to document that you should use that version of the framework with Xcode 7.3.1.

friedbunny
friedbunny reviewed Apr 24, 2017
View reviewed changes
platform/macos/CHANGELOG.md Outdated
@@ -10,6 +10,7 @@

### Other changes

* Xcode 8.0 or higher is now recommended for using this SDK. ([#8775(https://github.com/mapbox/mapbox-gl-native/pull/8775)======
Copy link
Contributor

@friedbunny friedbunny Apr 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a few extra = snuck in here. (And the link is bork.)

@jmkiley jmkiley merged commit a87fd1a into master Apr 25, 2017
@jmkiley jmkiley deleted the jmkiley-xcode-8 branch April 25, 2017 00:04
@boundsj boundsj added this to iOS-v3.6.0 Completed in iOS SDK v3.6.0 tracking May 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@friedbunny friedbunny friedbunny approved these changes

@1ec5 1ec5 1ec5 approved these changes

Assignees

@jmkiley jmkiley

Labels
build iOS Mapbox Maps SDK for iOS
Projects
No open projects
iOS SDK v3.6.0 tracking
iOS-v3.6.0 Completed
Milestone
ios-v3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmkiley @friedbunny @1ec5