This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Rework instrumentation tests #8793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugaldia
approved these changes
Apr 21, 2017
|
@tobrun PR looks good though I just realized CI is complaining of checkstyle issues in the Test App. |
tobrun
force-pushed
the
tvn-instrumentation-testing
branch
3 times, most recently
from
ba66f39
to
d040e5f
Compare
tobrun
force-pushed
the
tvn-instrumentation-testing
branch
from
d040e5f
to
198d06d
Compare
This was referenced May 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8547
This PR reworks the instrumentation test to not use MapboxMap in
@before. This solves the issue of #8547 where we are running in a race condition that the MapboxMap wasn't actually ready to start executing the tests. This is because we are posting the MapboxMap creation at the end of the message queue. With this change, I reworked the tests into using a base test class and introduced avalidateTestSetupmethod. This method currently asserts if we have an active internet connection. This should make identifying device issues easier on CI (as it would currently fail with an obscure espresso exception).