Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios, macos] Fix size and color of default marker image #9370

Merged
merged 1 commit into from Jun 26, 2017

Conversation

friedbunny
Copy link
Contributor

@friedbunny friedbunny commented Jun 26, 2017

Fixes #9361 by enbiggening the default marker on iOS and macOS, back to the size it had in v3.5.x (before #9060). Makes the macOS and iOS marker dimensions the same.

Also fixes a discrepancy in the color of the raster markers and the SVG — the SVG and PDFs have been updated to match the brighter red color in v3.5.x.

Color discrepancy

screen shot 2017-06-26 at 12 37 44 pm
left: incorrect darker fill, right: correct brighter raster fill

Updated markers

simulator screen shot jun 26 2017 12 40 06 pm

screen shot 2017-06-26 at 12 48 45 pm

/cc @1ec5 @nickidlugash

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Jun 26, 2017
@friedbunny friedbunny added this to the ios-v3.6.0 milestone Jun 26, 2017
@friedbunny friedbunny self-assigned this Jun 26, 2017
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great on iOS. Be sure to verify the hit targets, since the alignment rect insets haven’t changed.

My only other concern regarding macOS is that the larger default annotation takes up a little too much room considering the relative precision of Mac input devices. On the other hand, consistency between the two platforms is also a plus. Assuming we keep the larger size, can you add a blurb to the macOS changelog noting that change?

@friedbunny
Copy link
Contributor Author

friedbunny commented Jun 26, 2017

Be sure to verify the hit targets, since the alignment rect insets haven’t changed.

Alignment rect calculation is dynamic and the aspect/proportions of the images are the same, so we should be good.

My only other concern regarding macOS is that the larger default annotation takes up a little too much room considering the relative precision of Mac input devices.

I think the visual consistency is worth it — looking at desktop Apple Maps, the style/pin proportions are the same as in iOS MapKit. Using our maps, switching to macOS and seeing the smaller markers always left me with a sense of discordance for a bit, and this eliminates that.

I’ll update the macOS changelog. 🙇

@1ec5
Copy link
Contributor

1ec5 commented Jun 26, 2017

looking at desktop Apple Maps, the style/pin proportions are the same as in iOS

True, although the pin’s slender shape ensures that a few pins on the map won’t have an overpowering visual effect. I guess we can revisit that when we consider a whoopee-cushion-shaped default annotation image, right? 😛

@friedbunny
Copy link
Contributor Author

friedbunny commented Jun 26, 2017

Circle/GitHub are having issues today and these builds got stuck:

Looks like we had a bug in our infrastructure, or that of our providers (generally GitHub or AWS). We should have automatically retried this build. We've been alerted of the issue and are almost certainly looking into it, please contact us if you're interested in the cause or if the problem persists.

@friedbunny friedbunny merged commit 361dda2 into release-ios-v3.6.0-android-v5.1.0 Jun 26, 2017
@friedbunny friedbunny deleted the fb-marker-size-color branch June 26, 2017 20:39
@fabian-guerra fabian-guerra added this to iOS-v3.6.0 Completed in iOS SDK v3.6.0 tracking Jun 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
No open projects
iOS SDK v3.6.0 tracking
iOS-v3.6.0 Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants