This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Update script detection for Unicode 10 #9401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLoer
suggested changes
Jul 5, 2017
src/mbgl/util/i18n.cpp
Outdated
| @@ -239,9 +240,12 @@ DEFINE_IS_IN_UNICODE_BLOCK(HalfwidthandFullwidthForms, 0xFF00, 0xFFEF) | |||
| // DEFINE_IS_IN_UNICODE_BLOCK(Takri, 0x11680, 0x116CF) | |||
| // DEFINE_IS_IN_UNICODE_BLOCK(Ahom, 0x11700, 0x1173F) | |||
| // DEFINE_IS_IN_UNICODE_BLOCK(WarangCiti, 0x118A0, 0x118FF) | |||
| // DEFINE_IS_IN_UNICODE_BLOCK(ZanabazarSquare, 0x11A00, 0x11A00) | |||
There was a problem hiding this comment.
Doesn't this block actually end at 0x11a4f?
There was a problem hiding this comment.
Wow, good eye! Fixed in 3d50fd902e0ce480e2d12f7a583ffc53c4a004e0.
There was a problem hiding this comment.
Also fixed in mapbox/mapbox-gl-js#4940.
ChrisLoer
approved these changes
Jul 6, 2017
Updated script detection code to reflect changes in Unicode 10 and UTR 50 revision 17.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the script detection code to reflect changes in Unicode 10 and UTR #50 revision 17.
This is a port of mapbox/mapbox-gl-js#4919.
/cc @ChrisLoer