This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
port backendscope changes to release branch #9538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Guards against duplicate activations by checking wether the backend of the prior scope is the same as the current ones - Makes sure that only the most outer backend scope deactivates by tracking activation state
ivovandongen
added
Android
ivovandongen
changed the title
|
@1ec5 I've tested this on iOS. Tests pass and the app works as expected still. Tagged you for review to be sure. |
1ec5
approved these changes
Jul 19, 2017
tobrun
approved these changes
Jul 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports backend scope changes that make manual reference counting on android for backend activation/deactivation obsolete.
Fixes #9458
@zugaldia I tagged you for review as you reported #9458 and I'm not sure how to reproduce.