This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Do not check connection if local request #9968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests to servers which run on localhost should be independent from internet connection.
tobrun
force-pushed
the
external-pr-rjuszczyk
branch
from
70b27b4
to
3f5c1f1
Compare
zugaldia
reviewed
Sep 12, 2017
| @@ -56,13 +56,14 @@ private HTTPRequest(long nativePtr, String resourceUrl, String etag, String modi | |||
| mNativePtr = nativePtr; | |||
|
|
|||
| try { | |||
| // Don't try a request if we aren't connected | |||
| if (!Mapbox.isConnected()) { | |||
| HttpUrl httpUrl = HttpUrl.parse(resourceUrl); | |||
There was a problem hiding this comment.
Mmrm this code wasn't in the original PR, why was it introduced?
There was a problem hiding this comment.
I triple checked it and the code in
is the same except for formatting ( I rebased and fixed-up my formatting commit).
There was a problem hiding this comment.
@tobrun Thanks for checking, it must be a diff artifact.
zugaldia
approved these changes
Sep 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from external PR in #9862 to allow CI to execute.
cc @rjuszczyk