-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added approaches request paramenter to Directions and MapMatching #827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@osana this looks good thanks for the work on this! Just some minor javadoc updates to update before merging - will still unblock you ✅
@@ -678,6 +683,31 @@ public Builder radiuses(@FloatRange(from = 0) double... radiuses) { | |||
|
|||
abstract Builder coordinates(@NonNull List<Point> coordinates); | |||
|
|||
|
|||
/** | |||
* Optionally used to indicate how map matched routes consider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is how map matched
a typo here?
|
||
abstract Builder approaches(@Nullable String approaches); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT extra line
@@ -239,6 +239,24 @@ public static Builder builder() { | |||
@NonNull | |||
public abstract String requestUuid(); | |||
|
|||
/** | |||
* Used to indicate how map matched routes consider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make this javadoc not specific to map match vs. directions API, as it's used in both
closes #820