Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate gesture settings increaseRotateThresholdWhenPinchingToZoom #1632

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -3,6 +3,7 @@
Mapbox welcomes participation and contributions from everyone.
# main
## Features ✨ and improvements 🏁
* Deprecated gesture settings `increaseRotateThresholdWhenPinchingToZoom` property. ([1632](https://github.com/mapbox/mapbox-maps-android/pull/1632))

## Bug fixes 🐞
* Fix scale bar truncated at high zoom levels near the poles. ([1620](https://github.com/mapbox/mapbox-maps-android/pull/1620))
Expand Down
3 changes: 2 additions & 1 deletion plugin-gestures/src/main/res-public/values/public.xml
Expand Up @@ -43,7 +43,8 @@
<!-- Whether a deceleration animation following a scroll gesture is enabled. True by default. -->
<public name="mapbox_gesturesScrollDecelerationEnabled" type="attr" />

<!-- Whether rotate threshold increases when pinching to zoom. true by default. -->
<!-- Whether rotate threshold increases when pinching to zoom. true by default.
{@deprecated This property has no effect} -->
<public name="mapbox_gesturesIncreaseRotateThresholdWhenPinchingToZoom" type="attr" />

<!-- Whether pinch to zoom threshold increases when rotating. true by default. -->
Expand Down
6 changes: 3 additions & 3 deletions sdk-base/api/metalava.txt
Expand Up @@ -1839,7 +1839,7 @@ package com.mapbox.maps.plugin.gestures.generated {
method public boolean getDoubleTouchToZoomOutEnabled();
method public com.mapbox.maps.ScreenCoordinate? getFocalPoint();
method public boolean getIncreasePinchToZoomThresholdWhenRotating();
method public boolean getIncreaseRotateThresholdWhenPinchingToZoom();
method @Deprecated public boolean getIncreaseRotateThresholdWhenPinchingToZoom();
method public boolean getPinchScrollEnabled();
method public boolean getPinchToZoomDecelerationEnabled();
method public boolean getPinchToZoomEnabled();
Expand All @@ -1857,7 +1857,7 @@ package com.mapbox.maps.plugin.gestures.generated {
method public void setDoubleTouchToZoomOutEnabled(boolean doubleTouchToZoomOutEnabled);
method public void setFocalPoint(com.mapbox.maps.ScreenCoordinate? focalPoint);
method public void setIncreasePinchToZoomThresholdWhenRotating(boolean increasePinchToZoomThresholdWhenRotating);
method public void setIncreaseRotateThresholdWhenPinchingToZoom(boolean increaseRotateThresholdWhenPinchingToZoom);
method @Deprecated public void setIncreaseRotateThresholdWhenPinchingToZoom(boolean increaseRotateThresholdWhenPinchingToZoom);
method public void setPinchScrollEnabled(boolean pinchScrollEnabled);
method public void setPinchToZoomDecelerationEnabled(boolean pinchToZoomDecelerationEnabled);
method public void setPinchToZoomEnabled(boolean pinchToZoomEnabled);
Expand All @@ -1875,7 +1875,7 @@ package com.mapbox.maps.plugin.gestures.generated {
property public abstract boolean doubleTouchToZoomOutEnabled;
property public abstract com.mapbox.maps.ScreenCoordinate? focalPoint;
property public abstract boolean increasePinchToZoomThresholdWhenRotating;
property public abstract boolean increaseRotateThresholdWhenPinchingToZoom;
property @Deprecated public abstract boolean increaseRotateThresholdWhenPinchingToZoom;
property public abstract boolean pinchScrollEnabled;
property public abstract boolean pinchToZoomDecelerationEnabled;
property public abstract boolean pinchToZoomEnabled;
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.