Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump common sdk to 23.0.1. #1709

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Bump common sdk to 23.0.1. #1709

merged 2 commits into from
Sep 30, 2022

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented Sep 30, 2022

Summary of changes

  • Fix a potential style load error when non-ASCII characters are used in the version name, by escaping non US ASCII characters in user-agent header.
  • Bump common sdk to 23.0.1.

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2022

CLA assistant check
All committers have signed the CLA.

@pengdev pengdev changed the base branch from main to v10.8 September 30, 2022 08:36
@pengdev pengdev self-assigned this Sep 30, 2022
@pengdev pengdev marked this pull request as ready for review September 30, 2022 08:41
@pengdev pengdev requested a review from a team as a code owner September 30, 2022 08:41
@pengdev pengdev requested a review from tobrun September 30, 2022 09:58
@pengdev pengdev merged commit 3e4b07c into v10.8 Sep 30, 2022
@pengdev pengdev deleted the peng-bump-common-23.0.1 branch September 30, 2022 10:04
kiryldz pushed a commit that referenced this pull request Aug 2, 2023
…ap, deprecate previous constructor and bitmap/image setters. (#1709)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants