Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gl-native 10.9.0, common 23.1.1. #1760

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Bump gl-native 10.9.0, common 23.1.1. #1760

merged 4 commits into from
Oct 21, 2022

Conversation

yunikkk
Copy link
Contributor

@yunikkk yunikkk commented Oct 19, 2022

Summary of changes

Features ✨ and improvements 🏁

  • Updated mapbox-common to v23.1.1.
  • Introduced location-indicator-opacity to location indicator layer that allows to control layer opacity.
  • Rendering performance improvements for fast paced camera changes

Bug fixes 🐞

  • Fixed flickering of vertically shifted line labels on style change, caused by the wrong initial placement.
  • Fixed location indicator rendering as a rectangle on low zoom levels.
  • Fixed crash caused by using of invalid paint property binders.
  • Fixed "phantom tiles" artefacts after GeoJSON source update when asynchronous tile loading is enabled.
  • Mitigated symbol flickering on zooming out globe map.
  • Fixed random crash on tiles update when asynchronous uploading is enabled.
  • Fixed pixel flickering between tiles with darker styles in globe view.
  • Location indicator layer now occluded by terrain to align rendering behavior with other location indicator rendering types.
  • Fixed symbol flickering after runtime styling caused by using outdated symbol placement on updated symbol buckets.
  • Allow Light intensity and Light shadow intensity to accept expressions when using setStyleLight API call.
  • Fixed a bug in cameraForGeometry when called on a map with padding set.

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@yunikkk yunikkk requested a review from a team as a code owner October 19, 2022 09:19
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have our Android SDK delta between rc and stable in the changelog but we have full gl-native changelog (including changes for beta, rc and stable). We need to align it - either add all our SDK changes here as well or understand what's the gl-native delta between rc and stable.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the comment

@yunikkk yunikkk changed the title Bump gl-native 10.9.0, common 23.1.0. Bump gl-native 10.9.0, common 23.1.1. Oct 21, 2022
@yunikkk yunikkk force-pushed the yds-bump-gl-native branch 3 times, most recently from 8ade179 to b2a1912 Compare October 21, 2022 09:46
CHANGELOG.md Outdated Show resolved Hide resolved
@yunikkk yunikkk merged commit ae39d79 into main Oct 21, 2022
@yunikkk yunikkk deleted the yds-bump-gl-native branch October 21, 2022 10:26
kiryldz pushed a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants