Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snapshot features #386

Merged
merged 161 commits into from
Apr 25, 2024
Merged

Add Snapshot features #386

merged 161 commits into from
Apr 25, 2024

Conversation

lantah-1
Copy link
Contributor

What does this pull request do?

Added the functionality to retrieve map snapshots.

What is the motivation and context behind this change?

Translate the official Snapshotter API to make it more user-friendly.

Pull request checklist:

  • Add a changelog entry.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.

evil159 and others added 13 commits January 18, 2024 11:00
Update README.md according to the v11 changes
* Bump Mapbox Maps SDK to v11.1

* Add a changelog entry

* Bump version number in the podpec

* Adopt Maps SDK v11.1 changes in tests
…ordinates` (mapbox#359)

* Make padding nullable in cameraForCoordinateBounds and cameraForCoordinates

* Add changelog entry
* Add missing changelog entries

* Add missing docs
* Fix initial camera options not being applied on Android

* Add changelog entry
* update podfile.lock
* update podspec.lock
* fix MapOptions creation invalid index access (mapbox#379)

* Add changelog entry

---------

Co-authored-by: Ivan Ljubicic <76993460+LjubiTech-Maxko@users.noreply.github.com>
---------

Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
@lantah-1 lantah-1 requested review from a team as code owners January 31, 2024 06:49
@evil159
Copy link
Contributor

evil159 commented Feb 2, 2024

@lantah-1 Thank you for your contribution! Looks awesome, I'll do a review round later on. Could you also publish the template for SnapshotterMessager meanwhile?

@lantah-1
Copy link
Contributor Author

lantah-1 commented Feb 4, 2024

@lantah-1 Thank you for your contribution! Looks awesome, I'll do a review round later on. Could you also publish the template for SnapshotterMessager meanwhile?

Of course, thank you for your recognition! Here is my template. To maintain consistency, I made slight modifications after generating the template. If you have any better suggestions, I'm open to discussing them together.

@figureai
Copy link

figureai commented Mar 7, 2024

May I ask when this feature can be merged?

@evil159 evil159 changed the base branch from main to rl/snapshotter April 15, 2024 11:20
@evil159 evil159 deleted the branch mapbox:rl/snapshotter April 15, 2024 11:21
@evil159 evil159 closed this Apr 15, 2024
@evil159 evil159 reopened this Apr 15, 2024
@evil159 evil159 changed the base branch from rl/snapshotter to main April 15, 2024 11:23
@evil159 evil159 changed the base branch from main to rl/snapshotter April 15, 2024 11:23
@evil159
Copy link
Contributor

evil159 commented Apr 25, 2024

@lantah-1 Thank you for your contribution! We are merging your PR into an internal branch and continuing there.

@evil159 evil159 merged commit 3db795c into mapbox:rl/snapshotter Apr 25, 2024
@evil159 evil159 mentioned this pull request Apr 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants