Snapshotter #512
Merged
Snapshotter #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2024
pjleonard37
approved these changes
Apr 30, 2024
|
Looks great, @evil159! 📸 |
Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
* Add method to capture snapshot from mapbox map * Change snapshot type to int list * Add integration test
Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
…r into rl/snapshotter
bf-vs
reviewed
May 1, 2024
| onStyleImageMissingListener: widget.onStyleImageMissingListener, | ||
| onStyleImageUnusedListener: widget.onStyleImageUnusedListener, | ||
| onResourceRequestListener: widget.onResourceRequestListener, | ||
| onMapTapListener: widget.onTapListener, |
There was a problem hiding this comment.
onMapTapListener does no longer works in our app after this commit. Should we migrate to something else. If so what is it?
There was a problem hiding this comment.
Thanks for the heads up, this was removed accidentally, it is restored in #526
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This PR exposes
Snapshotterand introduces refactored event handing forMapWidgetthat is also reused forSnapshotter. Event listeners(map loaded, style loaded, map idle etc.) are no longer being ignored afterMapWidgetstate initialization, they can be updated dynamically.Based #386.
Addresses #210, #279, https://mapbox.atlassian.net/browse/MAPSFLT-159
What is the motivation and context behind this change?
Snapshotterprovides a way to get an image snapshot of a map without instantiating aMapWidgetPull request checklist: