Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] rework e2e integration trigger by using labels versus on-hold jobs #1449

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jul 12, 2022

This PR introduces a new way to trigger end-to-end compatibility verification. This now happens by including a label.

@tobrun tobrun added skip changelog Add this label if this item does not need to be included in the changelog run_e2e labels Jul 12, 2022
@jmalanen jmalanen marked this pull request as ready for review August 17, 2022 14:00
@jmalanen jmalanen requested a review from a team as a code owner August 17, 2022 14:00
@CLAassistant
Copy link

CLAassistant commented Sep 1, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@evil159 evil159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment!

Comment on lines 468 to 471
command: |
curl -Ls https://mapbox-release-engineering.s3.amazonaws.com/mbx-ci/latest/mbx-ci-linux-amd64 > mbx-ci && chmod 755 ./mbx-ci
./mbx-ci aws setup
name: Install mbx-ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have install-mbx-ci command that seem to be doing pretty much the same thing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - switched to the existing command. I made couple small fixes to it to get it working.

@jmalanen jmalanen force-pushed the tvn-e2e branch 3 times, most recently from 34790a9 to c5fdb3a Compare September 1, 2022 14:13
Co-authored-by: Juha Alanen <juha.alanen@mapbox.com>
@jmalanen jmalanen merged commit 88f807d into main Sep 2, 2022
@jmalanen jmalanen deleted the tvn-e2e branch September 2, 2022 07:51
maios added a commit that referenced this pull request Mar 29, 2023
maios added a commit that referenced this pull request Mar 29, 2023
evil159 pushed a commit that referenced this pull request Mar 31, 2023
maios added a commit that referenced this pull request Mar 31, 2023
* Remove unused RotationGestureHandler/scheduleRotationUpdateIfNeeded (#1442)

* Bump MapboxCoreMaps to v10.12.1 (#1449)

---------

Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com>
Co-authored-by: Ivan Persidsky <ivan.persidskii@mapbox.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
OdNairy pushed a commit that referenced this pull request Apr 5, 2023
OdNairy pushed a commit that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_e2e skip changelog Add this label if this item does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants