-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] rework e2e integration trigger by using labels versus on-hold jobs #1449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor comment!
.circleci/config.yml
Outdated
command: | | ||
curl -Ls https://mapbox-release-engineering.s3.amazonaws.com/mbx-ci/latest/mbx-ci-linux-amd64 > mbx-ci && chmod 755 ./mbx-ci | ||
./mbx-ci aws setup | ||
name: Install mbx-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have install-mbx-ci
command that seem to be doing pretty much the same thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - switched to the existing command. I made couple small fixes to it to get it working.
34790a9
to
c5fdb3a
Compare
Co-authored-by: Juha Alanen <juha.alanen@mapbox.com>
* Remove unused RotationGestureHandler/scheduleRotationUpdateIfNeeded (#1442) * Bump MapboxCoreMaps to v10.12.1 (#1449) --------- Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Ivan Persidsky <ivan.persidskii@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
This PR introduces a new way to trigger end-to-end compatibility verification. This now happens by including a label.