Add support for heading calibration alert #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OdNairy
previously requested changes
Aug 3, 2022
maios
reviewed
Aug 10, 2022
| @@ -40,3 +40,7 @@ internal class EmptyLocationProviderDelegate: LocationProviderDelegate { | |||
| func locationProvider(_ provider: LocationProvider, didUpdateLocations locations: [CLLocation]) {} | |||
| func locationProviderDidChangeAuthorization(_ provider: LocationProvider) {} | |||
| } | |||
|
|
|||
| internal protocol CalibratingLocationProviderDelegate: LocationProviderDelegate { | |||
| func locationProviderShouldDisplayHeadingCalibration(_ locationProvider: LocationProvider) -> Bool | |||
There was a problem hiding this comment.
as discussed, we should have this as part of public LocationProviderDelegate so custom LocationProvider can have one possible channel of communicating back to LocationManager to consult whether or not should calibration alert be displayed.
There was a problem hiding this comment.
Adding another method to a public protocol would be a breaking change and we need to verify that methods with default implementation are dispatched correctly before using those.
maios
approved these changes
Aug 10, 2022
evil159
dismissed
OdNairy’s stale review
Dismissed as the requested changes are done.
mapbox-github-ci-writer-public-1 bot
pushed a commit
that referenced
this pull request
May 3, 2023
…) (#1509) * [CarPlay] Get associated scene of a window in CarPlay dashboard. - When a CarPlay application is displaying with a dashboard, a window in the dashboard scene will not have an associated windowScene, instead we need to check if the notification's scene if it contains the map's window and pause display link accordingly.
mapbox-github-ci-writer-public-1 bot
pushed a commit
that referenced
this pull request
May 5, 2023
* [CarPlay] Get associated scene of a window in CarPlay dashboard. (#1503) (#1509) * [CarPlay] Get associated scene of a window in CarPlay dashboard. - When a CarPlay application is displaying with a dashboard, a window in the dashboard scene will not have an associated windowScene, instead we need to check if the notification's scene if it contains the map's window and pause display link accordingly. * [v10] Expose ModelLayer api (#1513) * Prepare release v10.13.1 (#1515) * Expose Style/addMode(modelId:modelUri:) as experimental) (#1521)
OdNairy
pushed a commit
that referenced
this pull request
Aug 22, 2023
…) (#1509) * [CarPlay] Get associated scene of a window in CarPlay dashboard. - When a CarPlay application is displaying with a dashboard, a window in the dashboard scene will not have an associated windowScene, instead we need to check if the notification's scene if it contains the map's window and pause display link accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to location manager's delegate protocol to provide the ability to display the heading calibration alert on top of the current window immediately.
Public API changes
LocationPermissionsDelegate.locationManagerShouldDisplayHeadingCalibration(_:) -> BooladdedPull request checklist:
custom_categories(scripts/doc-generation/.jazzy.yaml)## mainheading near the top).PRs must be submitted under the terms of our Contributor License Agreement CLA.