Fix issue with map spinning when setting destBearing and sourceBearing to 102 #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this PR! The team is taking a look now |
9 tasks
|
Thanks @NiwakaDev for another contribution! 🚀 PR base branch was changed, you can track the second PR phase in #1828 |
OdNairy
added a commit
that referenced
this pull request
Jan 26, 2023
* Force previous fastlane version (#1848) * Fix issue with map spinning when setting destBearing and sourceBearing to 102 (#1793) (#1828) Co-authored-by: Niwaka <61189782+NiwakaDev@users.noreply.github.com> * Update submodules SSH key (#1854) * Enable CircleCI contexts for shared environment variables (#1852) * Use the latest v4 Slack Orb * Add 'Slack Orb' context for each job * MAPSIOS-556: Adopt shared context for CocoaPods trunk token * MAPSIOS-558: Adopt shared context for Fastlane Match password * MAPSIOS-557: Adopt shared context for SDK Registry token * MAPSIOS-555: Adopt shared context for Apple credentials/ASC token * Remove unused license template (#1857) * Fix missing contexts, reuse CircleCI token (#1859) * Enable GoogleCloud shared credentials (#1861) * Enable 'Retry on Failure' up to 3 times for all tests (#1860) * Add missing public mapbox token (#1863) * Run IntegrationTests even when unit tests failing (#1864) * Add Mapbox public token to unit tests (#1865) * Move mapbox token to build unit tests (#1866) * Add public Mapbox token to build unit test jobs * Revert "Add Mapbox public token to unit tests (#1865)" This reverts commit efba681. * Improve stability of attribution parsing (#1849) * Mapsios 567 mark no op and deprecate v10.11.0 properties (#1867) * Extract integration tests to the separate CircleCI job (#1870) * Rename job to build host tests * Rename job to build tests * Rename job to build firebase tests * Rename Build tests job * Run integration tests * Code coverage command * Enable codecoverage by default * Run integration tests on nightly bases * Utilize default values for run-integration-tests job * Remove unused arg * Enable Expression to be created without an operator (#1855) * Change clusterProperties to accept array * Break up expression and reassemble for clusterProperties * Adjust example so app can run * Introduce operatorless expression * Add additional tests, update comments * Enable operatorless encoding, add tests * Add property back, update filtering * Remove generated update * Fix argument and operator access * Update Sources/MapboxMaps/Style/Types/Expression.swift Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Add changelog, update expression operator to simplify Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Bump activesupport from 6.1.5 to 6.1.7.2 in /scripts/doc-generation (#1874) Bumps [activesupport](https://github.com/rails/rails) from 6.1.5 to 6.1.7.2. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.0.4.2/activesupport/CHANGELOG.md) - [Commits](rails/rails@v6.1.5...v6.1.7.2) --- updated-dependencies: - dependency-name: activesupport dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Maps versions (#1875) * Update CoreMaps and Common * Update license * Update changelog * Generate development DocC on PR merges (#1873) * Generate DocC * Upload DocC to the 'latest' * Fix test results collection * Debug * Extra push to force CI trigger * Last fixes * Code review fixes * Add 10.11.0-rc.1 changelog entry (#1876) * Update SDK version (#1877) * Add missing changelog for #1828 (#1880) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Niwaka <61189782+NiwakaDev@users.noreply.github.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
persidskiy
added a commit
that referenced
this pull request
Feb 24, 2023
* Fix issue with map spinning when setting destBearing and sourceBearing to 102 (#1793) (#1828) Co-authored-by: Niwaka <61189782+NiwakaDev@users.noreply.github.com> * Enable CircleCI contexts for shared environment variables (#1852) * Use the latest v4 Slack Orb * Add 'Slack Orb' context for each job * MAPSIOS-556: Adopt shared context for CocoaPods trunk token * MAPSIOS-558: Adopt shared context for Fastlane Match password * MAPSIOS-557: Adopt shared context for SDK Registry token * MAPSIOS-555: Adopt shared context for Apple credentials/ASC token * Remove unused license template (#1857) * Fix missing contexts, reuse CircleCI token (#1859) * Enable GoogleCloud shared credentials (#1861) * Enable 'Retry on Failure' up to 3 times for all tests (#1860) * Add missing public mapbox token (#1863) * Run IntegrationTests even when unit tests failing (#1864) * Add Mapbox public token to unit tests (#1865) * Move mapbox token to build unit tests (#1866) * Add public Mapbox token to build unit test jobs * Revert "Add Mapbox public token to unit tests (#1865)" This reverts commit efba681. * Improve stability of attribution parsing (#1849) * Mapsios 567 mark no op and deprecate v10.11.0 properties (#1867) * Extract integration tests to the separate CircleCI job (#1870) * Rename job to build host tests * Rename job to build tests * Rename job to build firebase tests * Rename Build tests job * Run integration tests * Code coverage command * Enable codecoverage by default * Run integration tests on nightly bases * Utilize default values for run-integration-tests job * Remove unused arg * Enable Expression to be created without an operator (#1855) * Change clusterProperties to accept array * Break up expression and reassemble for clusterProperties * Adjust example so app can run * Introduce operatorless expression * Add additional tests, update comments * Enable operatorless encoding, add tests * Add property back, update filtering * Remove generated update * Fix argument and operator access * Update Sources/MapboxMaps/Style/Types/Expression.swift Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Add changelog, update expression operator to simplify Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Bump activesupport from 6.1.5 to 6.1.7.2 in /scripts/doc-generation (#1874) Bumps [activesupport](https://github.com/rails/rails) from 6.1.5 to 6.1.7.2. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.0.4.2/activesupport/CHANGELOG.md) - [Commits](rails/rails@v6.1.5...v6.1.7.2) --- updated-dependencies: - dependency-name: activesupport dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Maps versions (#1875) * Update CoreMaps and Common * Update license * Update changelog * Generate development DocC on PR merges (#1873) * Generate DocC * Upload DocC to the 'latest' * Fix test results collection * Debug * Extra push to force CI trigger * Last fixes * Code review fixes * Add 10.11.0-rc.1 changelog entry (#1876) * Update SDK version (#1877) * Add missing changelog for #1828 (#1880) * Skip codecov for Xcode 12.5.1 (#1879) * Replace test skips with failures (#1862) * Couple of fixes for release workflow (#1883) * Add basic signposts for rendering tracing (#1818) * Add basic signposts for rendering tracing * turn on signposts in tests Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Niwaka <61189782+NiwakaDev@users.noreply.github.com> Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ivan Persidsky <ivan.persidskii@mapbox.com>
mapbox-github-ci-writer-public-1 bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
* Bump core and common to v11 beta.4 * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1781.
Before this change, there is the map spinning when setting destBearing and sourceBearing to 102. I found that it seems to be related to a type method called Utils.normalize.
In addition, I appended a new unit test.
Pull request checklist:
custom_categories(scripts/doc-generation/.jazzy.yaml)## mainheading near the top).v10.[version]release branch fix / enhancement, merge it tomainfirst and then port tov10.[version]release branch.PRs must be submitted under the terms of our Contributor License Agreement CLA.