Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract integration tests to the separate CircleCI job #1870

Merged
merged 10 commits into from
Jan 24, 2023

Conversation

OdNairy
Copy link
Contributor

@OdNairy OdNairy commented Jan 24, 2023

Pull request checklist:

  • Describe the changes in this PR, especially public API changes.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. Put tests in correct Test Plan (Unit, Integration, All)
    • If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.
  • Add any new public, top-level symbols to the Jazzy config's custom_categories (scripts/doc-generation/.jazzy.yaml)
  • Add a changelog entry to to bottom of the relevant section (typically the ## main heading near the top).
  • Update the guides (internal access only), README.md, and DEVELOPING.md if their contents are impacted by these changes.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main first and then port to v10.[version] release branch.

PRs must be submitted under the terms of our Contributor License Agreement CLA.

MAPSIOS-607
MAPSIOS-608

@OdNairy OdNairy force-pushed the feature/improve_integration_tests branch from a99493b to 1e11ce4 Compare January 24, 2023 09:41
@OdNairy OdNairy force-pushed the feature/improve_integration_tests branch from 1e11ce4 to 6b88472 Compare January 24, 2023 10:02
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #1870 (5f2ccb1) into main (72c364e) will increase coverage by 4.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
+ Coverage   84.69%   89.08%   +4.38%     
==========================================
  Files         242      242              
  Lines       15080    15080              
==========================================
+ Hits        12772    13434     +662     
+ Misses       2308     1646     -662     
Flag Coverage Δ
integration 56.69% <ø> (+38.41%) ⬆️
unit 83.62% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/MapboxMaps/Style/SourceType.swift 87.50% <0.00%> (ø)
Sources/MapboxMaps/Offline/OfflineErrors.swift 45.61% <0.00%> (ø)
Sources/MapboxMaps/Ornaments/LogoView.swift 96.88% <0.00%> (+0.08%) ⬆️
Sources/MapboxMaps/Foundation/MapView.swift 92.13% <0.00%> (+0.38%) ⬆️
Sources/MapboxMaps/Location/LocationProducer.swift 98.37% <0.00%> (+0.54%) ⬆️
...boxMaps/Annotations/OffsetGeometryCalculator.swift 69.10% <0.00%> (+0.56%) ⬆️
...Annotations/Generated/PointAnnotationManager.swift 93.00% <0.00%> (+0.63%) ⬆️
...otations/Generated/PolylineAnnotationManager.swift 91.70% <0.00%> (+1.24%) ⬆️
...nnotations/Generated/CircleAnnotationManager.swift 91.03% <0.00%> (+1.34%) ⬆️
...notations/Generated/PolygonAnnotationManager.swift 90.78% <0.00%> (+1.38%) ⬆️
... and 30 more

@OdNairy OdNairy force-pushed the feature/improve_integration_tests branch from 6b88472 to e5bd7a8 Compare January 24, 2023 10:26
@OdNairy OdNairy marked this pull request as ready for review January 24, 2023 10:54
@OdNairy OdNairy requested a review from a team as a code owner January 24, 2023 10:54
@OdNairy OdNairy requested a review from evil159 January 24, 2023 10:54
@OdNairy OdNairy force-pushed the feature/improve_integration_tests branch from 88a151c to 99444be Compare January 24, 2023 11:12
Copy link
Contributor

@evil159 evil159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍 Hopefully upload speed will improve for M1 runners after they are out of beta 🤞

@OdNairy OdNairy merged commit 4b54016 into main Jan 24, 2023
@OdNairy OdNairy deleted the feature/improve_integration_tests branch January 24, 2023 14:12
OdNairy added a commit that referenced this pull request Jan 26, 2023
* Force previous fastlane version (#1848)

* Fix issue with map spinning when setting destBearing and sourceBearing to 102 (#1793) (#1828)

Co-authored-by: Niwaka <61189782+NiwakaDev@users.noreply.github.com>

* Update submodules SSH key (#1854)

* Enable CircleCI contexts for shared environment variables (#1852)

* Use the latest v4 Slack Orb

* Add 'Slack Orb' context for each job

* MAPSIOS-556: Adopt shared context for CocoaPods trunk token

* MAPSIOS-558: Adopt shared context for Fastlane Match password

* MAPSIOS-557: Adopt shared context for SDK Registry token

* MAPSIOS-555: Adopt shared context for Apple credentials/ASC token

* Remove unused license template (#1857)

* Fix missing contexts, reuse CircleCI token (#1859)

* Enable GoogleCloud shared credentials (#1861)

* Enable 'Retry on Failure' up to 3 times for all tests (#1860)

* Add missing public mapbox token (#1863)

* Run IntegrationTests even when unit tests failing (#1864)

* Add Mapbox public token to unit tests (#1865)

* Move mapbox token to build unit tests (#1866)

* Add public Mapbox token to build unit test jobs

* Revert "Add Mapbox public token to unit tests (#1865)"

This reverts commit efba681.

* Improve stability of attribution parsing (#1849)

* Mapsios 567 mark no op and deprecate v10.11.0 properties (#1867)

* Extract integration tests to the separate CircleCI job (#1870)

* Rename job to build host tests

* Rename job to build tests

* Rename job to build firebase tests

* Rename Build tests job

* Run integration tests

* Code coverage command

* Enable codecoverage by default

* Run integration tests on nightly bases

* Utilize default values for run-integration-tests job

* Remove unused arg

* Enable Expression to be created without an operator (#1855)

* Change clusterProperties to accept array

* Break up expression and reassemble for clusterProperties

* Adjust example so app can run

* Introduce operatorless expression

* Add additional tests, update comments

* Enable operatorless encoding, add tests

* Add property back, update filtering

* Remove generated update

* Fix argument and operator access

* Update Sources/MapboxMaps/Style/Types/Expression.swift

Co-authored-by: Mai Mai <mai.mai@mapbox.com>

* Add changelog, update expression operator to simplify

Co-authored-by: Mai Mai <mai.mai@mapbox.com>

* Bump activesupport from 6.1.5 to 6.1.7.2 in /scripts/doc-generation (#1874)

Bumps [activesupport](https://github.com/rails/rails) from 6.1.5 to 6.1.7.2.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v7.0.4.2/activesupport/CHANGELOG.md)
- [Commits](rails/rails@v6.1.5...v6.1.7.2)

---
updated-dependencies:
- dependency-name: activesupport
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Maps versions (#1875)

* Update CoreMaps and Common

* Update license

* Update changelog

* Generate development DocC on PR merges (#1873)

* Generate DocC

* Upload DocC to the 'latest'

* Fix test results collection

* Debug

* Extra push to force CI trigger

* Last fixes

* Code review fixes

* Add 10.11.0-rc.1 changelog entry (#1876)

* Update SDK version (#1877)

* Add missing changelog for #1828 (#1880)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
Co-authored-by: Niwaka <61189782+NiwakaDev@users.noreply.github.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
Co-authored-by: Mai Mai <mai.mai@mapbox.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
persidskiy added a commit that referenced this pull request Feb 24, 2023
* Fix issue with map spinning when setting destBearing and sourceBearing to 102 (#1793) (#1828)

Co-authored-by: Niwaka <61189782+NiwakaDev@users.noreply.github.com>

* Enable CircleCI contexts for shared environment variables (#1852)

* Use the latest v4 Slack Orb

* Add 'Slack Orb' context for each job

* MAPSIOS-556: Adopt shared context for CocoaPods trunk token

* MAPSIOS-558: Adopt shared context for Fastlane Match password

* MAPSIOS-557: Adopt shared context for SDK Registry token

* MAPSIOS-555: Adopt shared context for Apple credentials/ASC token

* Remove unused license template (#1857)

* Fix missing contexts, reuse CircleCI token (#1859)

* Enable GoogleCloud shared credentials (#1861)

* Enable 'Retry on Failure' up to 3 times for all tests (#1860)

* Add missing public mapbox token (#1863)

* Run IntegrationTests even when unit tests failing (#1864)

* Add Mapbox public token to unit tests (#1865)

* Move mapbox token to build unit tests (#1866)

* Add public Mapbox token to build unit test jobs

* Revert "Add Mapbox public token to unit tests (#1865)"

This reverts commit efba681.

* Improve stability of attribution parsing (#1849)

* Mapsios 567 mark no op and deprecate v10.11.0 properties (#1867)

* Extract integration tests to the separate CircleCI job (#1870)

* Rename job to build host tests

* Rename job to build tests

* Rename job to build firebase tests

* Rename Build tests job

* Run integration tests

* Code coverage command

* Enable codecoverage by default

* Run integration tests on nightly bases

* Utilize default values for run-integration-tests job

* Remove unused arg

* Enable Expression to be created without an operator (#1855)

* Change clusterProperties to accept array

* Break up expression and reassemble for clusterProperties

* Adjust example so app can run

* Introduce operatorless expression

* Add additional tests, update comments

* Enable operatorless encoding, add tests

* Add property back, update filtering

* Remove generated update

* Fix argument and operator access

* Update Sources/MapboxMaps/Style/Types/Expression.swift

Co-authored-by: Mai Mai <mai.mai@mapbox.com>

* Add changelog, update expression operator to simplify

Co-authored-by: Mai Mai <mai.mai@mapbox.com>

* Bump activesupport from 6.1.5 to 6.1.7.2 in /scripts/doc-generation (#1874)

Bumps [activesupport](https://github.com/rails/rails) from 6.1.5 to 6.1.7.2.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v7.0.4.2/activesupport/CHANGELOG.md)
- [Commits](rails/rails@v6.1.5...v6.1.7.2)

---
updated-dependencies:
- dependency-name: activesupport
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Maps versions (#1875)

* Update CoreMaps and Common

* Update license

* Update changelog

* Generate development DocC on PR merges (#1873)

* Generate DocC

* Upload DocC to the 'latest'

* Fix test results collection

* Debug

* Extra push to force CI trigger

* Last fixes

* Code review fixes

* Add 10.11.0-rc.1 changelog entry (#1876)

* Update SDK version (#1877)

* Add missing changelog for #1828 (#1880)

* Skip codecov for Xcode 12.5.1 (#1879)

* Replace test skips with failures (#1862)

* Couple of fixes for release workflow (#1883)

* Add basic signposts for rendering tracing (#1818)

* Add basic signposts for rendering tracing

* turn on signposts in tests

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
Co-authored-by: Niwaka <61189782+NiwakaDev@users.noreply.github.com>
Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
Co-authored-by: Mai Mai <mai.mai@mapbox.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ivan Persidsky <ivan.persidskii@mapbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants