Ensure AnnotationManager's mapLoaded happens first #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
Add an entry inside this element for inclusion in theAdded directly to changelog in PRmapbox-maps-ios
changelog:<changelog></changelog>
.Update the migration guide, API Docs, Markdown files - Readme, Developing, etcSummary of changes
Previously, AnnotationManager subscribed to .mapLoaded using
MapboxCoreMaps directly; however, MapboxCoreMaps does not guarantee
that observers will be notified in the order in which they subscribe.
Among other things, this could result in annotations not being selected when they are tapped.
This fix updates AnnotationManager to subscribe via BaseMapView.on
which does guarantee notification ordering among its subscribers.
Breaking changes:
AnnotationManager
no longer conforms toObserver
and no longer has apeer
AnnotationSupportableMap
is now internal