Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure AnnotationManager's mapLoaded happens first #246

Merged
merged 5 commits into from
Apr 1, 2021
Merged

Ensure AnnotationManager's mapLoaded happens first #246

merged 5 commits into from
Apr 1, 2021

Commits on Apr 1, 2021

  1. Ensure AnnotationManager's mapLoaded happens first 

    Previously, AnnotationManager subscribed to .mapLoaded using
MapboxCoreMaps directly; however, MapboxCoreMaps does not guarantee
that observers will be notified in the order in which they subscribe.

This fix updates AnnotationManager to subscribe via BaseMapView.on
which does guarantee notification ordering among its subscribers.
    @macdrevx
    macdrevx committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    afb3853 View commit details
    Browse the repository at this point in the history

  2. Make AnnotationSupportableMap internal

    @macdrevx
    macdrevx committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    68b46a5 View commit details
    Browse the repository at this point in the history

  3. Test that AnnotationManager subscribes in init

    @macdrevx
    macdrevx committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    caa332c View commit details
    Browse the repository at this point in the history

  4. Update changelog

    @macdrevx
    macdrevx committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    8e67c41 View commit details
    Browse the repository at this point in the history

  5. Fix lint

    @macdrevx
    macdrevx committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    ffd1286 View commit details
    Browse the repository at this point in the history