-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out style from LocationSupportableMapView #352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrex
added
the
breaking change ⚠️
If your pull request introduces a breaking change and updates are required when version is published
label
May 13, 2021
7 tasks
julianrex
force-pushed
the
jrex/split-out-location-style
branch
from
May 17, 2021 14:31
7abf192
to
a8f7973
Compare
Hmm it feels like LocationSupportableMapView is basically obsolete? This is what locationSupportableMapView currently has: public protocol LocationSupportableMapView: UIView {
/// Matching the style property in `MapView`
var style: Style! { get }
/// Returns the screen coordinate for a given location coordinate (lat-long)
func screenCoordinate(for locationCoordinate: CLLocationCoordinate2D) -> ScreenCoordinate
/// Allows the `LocationSupportableMapView` to subscribe to a delegate
func subscribeRenderFrameHandler(_ handler: @escaping (MapboxCoreMaps.Event) -> Void)
/// Allows the `LocationSupportableMapView` to subscrive to a delegate function and handle style change events
func subscribeStyleChangeHandler(_ handler: @escaping (MapboxCoreMaps.Event) -> Void)
/// Gets meters per point at latitude for calculating accuracy ring
func metersPerPointAtLatitude(latitude: CLLocationDegrees) -> CLLocationDistance
} All these properties will soon be available on |
@nishant-karajgikar Yes, I think it will soon disappear, or mutate. |
nishant-karajgikar
approved these changes
May 17, 2021
neelmistry94
approved these changes
May 17, 2021
julianrex
force-pushed
the
jrex/split-out-location-style
branch
from
May 17, 2021 18:14
a8f7973
to
dce1e43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change ⚠️
If your pull request introduces a breaking change and updates are required when version is published
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-ios
changelog:<changelog>Removed style from LocationSupportableMapView</changelog>
.Summary of changes
This removes
LocationSupportableMapView.style
, moving it to a newLocationStyleDelegate
(naming mirroringAnnotationStyleDelegate
.This is a prelude to being able to move
Style
fromMapView
toMapboxMap
.