Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loadStyleURI/loadStyleJSON #354

Merged
merged 6 commits into from
May 17, 2021
Merged

Add loadStyleURI/loadStyleJSON #354

merged 6 commits into from
May 17, 2021

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented May 13, 2021 •
edited
Loading

Follows #352

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog>Added MapboxMap.loadStyleURIandMapboxMap.loadStyleJSON</changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

This PR:

  1. adds loadStyleURI and loadStyleJSON to MapboxMap
  2. moves Style from MapView to MapboxMap (since the above methods return Style in the completion closure)

@julianrex julianrex added the breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published label May 14, 2021
@julianrex julianrex force-pushed the jrex/split-out-location-style branch from 7abf192 to a8f7973 Compare May 17, 2021 14:31
@julianrex julianrex marked this pull request as ready for review May 17, 2021 17:37
@julianrex julianrex force-pushed the jrex/split-out-location-style branch from a8f7973 to dce1e43 Compare May 17, 2021 18:14
Base automatically changed from jrex/split-out-location-style to main May 17, 2021 18:39
@julianrex julianrex merged commit 128c54c into main May 17, 2021
@julianrex julianrex deleted the jrex/load-style-2 branch May 17, 2021 19:18
OdNairy pushed a commit that referenced this pull request Aug 22, 2023
@nishant-karajgikar
Merge pull request #354 from mapbox/nishantk/fix-debuggable-environment
647c725 
Fix submodule links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neelmistry94 neelmistry94 neelmistry94 approved these changes

@nishant-karajgikar nishant-karajgikar Awaiting requested review from nishant-karajgikar

Assignees
No one assigned
Labels
breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianrex @neelmistry94