Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Core beta.23 #388

Merged
merged 9 commits into from
May 24, 2021
Merged

Update to Core beta.23 #388

merged 9 commits into from
May 24, 2021

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented May 24, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog></changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

This PR:

  • updates to MapboxCoreMaps 10.0.0-beta.22, MapboxCommon 13.0.0, MapboxMobileEvents 1.0.0
  • Removes the Cartfile, Carthage directory and associated deps target from the makefile.
  • MBXFeature has been renamed Feature, MBXGeometry renamed as Geometry. Existing uses of the Turf types have been fully namespaced.
  • Removes the top-level MapboxMaps.xcworkspace, as it's no longer required.

@julianrex julianrex added the breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published label May 24, 2021
@julianrex julianrex changed the title Update to Core beta.230 Update to Core beta.23 May 24, 2021
Makefile Show resolved Hide resolved
Copy link
Contributor

@neelmistry94 neelmistry94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite a large change to drop Carthage so I'd request the following

  • scrub our CONTRIBUTING.md and DEVELOPING.md to remove any Carthage instructions
  • Add a changelog bullet that development environment is now on SPM and not carthage
  • Also, in our base.xcconfig, let's reenable warnings as errors. I have tested this and our builds do not fail anymore

DEVELOPING.md Outdated Show resolved Hide resolved
@julianrex julianrex merged commit cde53c6 into main May 24, 2021
@julianrex julianrex deleted the jrex/beta-23 branch May 24, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants