-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign single tap event handling for annotations #709
Merged
nishant-karajgikar
merged 9 commits into
main
from
nishantk/redesigned-tap-architecture
Sep 24, 2021
Merged
Redesign single tap event handling for annotations #709
nishant-karajgikar
merged 9 commits into
main
from
nishantk/redesigned-tap-architecture
Sep 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d6c0ae
to
e5703cd
Compare
Adding more tests.. |
macdrevx
reviewed
Sep 24, 2021
macdrevx
reviewed
Sep 24, 2021
Sources/MapboxMaps/Annotations/Generated/CircleAnnotationManager.swift
Outdated
Show resolved
Hide resolved
macdrevx
reviewed
Sep 24, 2021
Sources/MapboxMaps/Annotations/Generated/CircleAnnotationManager.swift
Outdated
Show resolved
Hide resolved
macdrevx
reviewed
Sep 24, 2021
Sources/MapboxMaps/Gestures/GestureHandlers/SingleTapGestureHandler.swift
Show resolved
Hide resolved
macdrevx
reviewed
Sep 24, 2021
Sources/MapboxMaps/Annotations/Generated/CircleAnnotationManager.swift
Outdated
Show resolved
Hide resolved
macdrevx
reviewed
Sep 24, 2021
macdrevx
reviewed
Sep 24, 2021
Sources/MapboxMaps/Gestures/GestureHandlers/SingleTapGestureHandler.swift
Show resolved
Hide resolved
macdrevx
reviewed
Sep 24, 2021
eb237d4
to
e9a64c3
Compare
macdrevx
approved these changes
Sep 24, 2021
27fdf18
to
5c50503
Compare
5c50503
to
f3257f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change ⚠️
If your pull request introduces a breaking change and updates are required when version is published
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Pull request checklist:
mapbox-maps-ios
changelog:<changelog></changelog>
.Summary of changes
This PR redesigns the way single tap gestures work in the MapView and each *AnnotationManager. The changes are motivated by a desire to make the
GestureManager
the home of all gesture related functionality. Accordingly, the GestureManager now owns aSingleTapGestureHandler
(and exposes its associated gesture recognizer).The
singleTapGestureRecognizer
is injected into theAnnotationsOrchestrator
and then into any constructed*AnnotationManager
s.From a user's perspective, setting the
AnnotationInteractionDelegate
on an annotation manger results in a target-action being added to the singleTapGestureRecognizer.