Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay adding InstructionView default click listeners until subscribed #1362

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Delay adding InstructionView default click listeners until subscribed #1362

merged 1 commit into from
Sep 30, 2018

Conversation

danesfeder
Copy link
Contributor

The InstructionView was initializing with click listeners that contained the NavigationViewModel. If the view never subscribed to the view model, a crash would occurs when clicking.

@danesfeder danesfeder added bug Defect to be fixed. ✓ ready for review labels Sep 30, 2018
@danesfeder danesfeder self-assigned this Sep 30, 2018
Guardiola31337
Guardiola31337 approved these changes Sep 30, 2018
View reviewed changes
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢:ship:

Thanks @danesfeder

@danesfeder danesfeder merged commit 4f3c829 into master Sep 30, 2018
@danesfeder danesfeder deleted the dan-button branch September 30, 2018 17:03
@danesfeder danesfeder mentioned this pull request Oct 1, 2018
Closed
11 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

@devotaaabel devotaaabel Awaiting requested review from devotaaabel

Assignees

@danesfeder danesfeder

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @Guardiola31337