Set ssmlAnouncement when using SpeechAnnouncementListener #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1675 +/- ##
============================================
- Coverage 26.24% 26.22% -0.02%
Complexity 786 786
============================================
Files 196 196
Lines 8342 8340 -2
Branches 597 597
============================================
- Hits 2189 2187 -2
Misses 5956 5956
Partials 197 197 |
danesfeder
force-pushed
the
dan-willvoice-ssml
branch
from
6239805
to
6e0b63b
Compare
danesfeder
added
the
backwards incompatible
Guardiola31337
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
Thanks for the fix here @danesfeder
Should we make sure / add a note to the Javadoc stating that if the ssmlAnnouncement is malformed it falls back to what is included in announcement and Android TTS?
danesfeder
force-pushed
the
dan-willvoice-ssml
branch
from
6e0b63b
to
bb868fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1577
SSML tags would never be considered with the current implementation. This PR reverts #1281 to make
SpeechAnnouncementListener#willVoicereturn aSpeechAnnouncementagain.