Bump NN #7753
Merged
Bump NN #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChangelogFeatures
Bug fixes and improvements
Known issues
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #7753 +/- ##
=========================================
Coverage 74.15% 74.16%
- Complexity 6263 6264 +1
=========================================
Files 855 856 +1
Lines 33757 33770 +13
Branches 4021 4022 +1
=========================================
+ Hits 25033 25044 +11
- Misses 7166 7168 +2
Partials 1558 1558
|
DzmitryFomchyn
force-pushed
the
df-adasis-nn
branch
2 times, most recently
from
1ed11b2
to
3066ce6
Compare
DzmitryFomchyn
force-pushed
the
df-adasis-nn
branch
from
31b5061
to
bd8bfaf
Compare
DzmitryFomchyn
force-pushed
the
df-adasis-nn
branch
from
bd8bfaf
to
a270495
Compare
DzmitryFomchyn
commented
Feb 26, 2024
dzinad
reviewed
Feb 26, 2024
| @@ -12,6 +12,8 @@ import com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI | |||
| * @param enableRetransmission if true, retransmission will be enabled | |||
| * (package will be appended with retransmission data, messages from previous cycles) | |||
| * @param retransmissionMeters after passing this distance, messages will not be retransmitted | |||
| * @param treeTrailingLength the trailing length of the path tree, relatively | |||
There was a problem hiding this comment.
It seems that both options are possible in this context :)
There was a problem hiding this comment.
I don't consider ChatGPT to be the true source of grammar, but:
libnavigation-core/src/main/java/com/mapbox/navigation/core/adas/AdasisDataSendingConfig.kt
Outdated
Show resolved
Hide resolved
kiryldz
reviewed
Feb 26, 2024
...core/src/main/java/com/mapbox/navigation/core/internal/MapboxNavigationSDKInitializerImpl.kt
Outdated
Show resolved
Hide resolved
kiryldz
requested changes
Feb 26, 2024
kiryldz
reviewed
Feb 26, 2024
| - Fix adasis generator errors related to the split edges. | ||
| - Fix adas cache tiles eviction mechanism. | ||
| - Handle "unlilimited" speed limits in Adasis. | ||
| - Fixed possible `java.lang.UnsatisfiedLinkError` crash on application startup when Mapbox native libraries could not yet be found. |
There was a problem hiding this comment.
Suggested change
| - Fixed possible `java.lang.UnsatisfiedLinkError` crash on application startup when Mapbox native libraries could not yet be found. | |
| - Fix possible `java.lang.UnsatisfiedLinkError` crash on application startup when Mapbox native libraries could not yet be found. |
to align with other records
There was a problem hiding this comment.
We actually use past simple in our changelog.
dzinad
approved these changes
Feb 26, 2024
| - Fix adasis generator errors related to the split edges. | ||
| - Fix adas cache tiles eviction mechanism. | ||
| - Handle "unlilimited" speed limits in Adasis. | ||
| - Fixed possible `java.lang.UnsatisfiedLinkError` crash on application startup when Mapbox native libraries could not yet be found. |
There was a problem hiding this comment.
We actually use past simple in our changelog.
| @@ -12,6 +12,8 @@ import com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI | |||
| * @param enableRetransmission if true, retransmission will be enabled | |||
| * (package will be appended with retransmission data, messages from previous cycles) | |||
| * @param retransmissionMeters after passing this distance, messages will not be retransmitted | |||
| * @param treeTrailingLength the trailing length of the path tree, relatively | |||
There was a problem hiding this comment.
I don't consider ChatGPT to be the true source of grammar, but:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump NN to https://github.com/mapbox/mapbox-navigation-native/releases/tag/202.0.0