Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address code review comments #7763

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Address code review comments #7763

merged 1 commit into from
Feb 28, 2024

Conversation

DzmitryFomchyn
Copy link
Contributor

Description

Follow up for #7753

@DzmitryFomchyn DzmitryFomchyn added the skip changelog Should not be added into version changelog. label Feb 26, 2024
@DzmitryFomchyn DzmitryFomchyn requested a review from a team as a code owner February 26, 2024 14:55
Copy link

github-actions bot commented Feb 26, 2024

Changelog

Features

Bug fixes and improvements

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

@DzmitryFomchyn DzmitryFomchyn force-pushed the df-adasis-nn-review branch 2 times, most recently from b0495c0 to c2b8f9a Compare February 26, 2024 14:56
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.16%. Comparing base (8f6012f) to head (4c8288c).

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #7763   +/-   ##
=========================================
  Coverage     74.16%   74.16%           
  Complexity     6264     6264           
=========================================
  Files           856      856           
  Lines         33770    33770           
  Branches       4022     4022           
=========================================
  Hits          25044    25044           
  Misses         7168     7168           
  Partials       1558     1558           
Files Coverage Δ
...ox/navigation/core/adas/AdasisDataSendingConfig.kt 97.40% <ø> (ø)

@DzmitryFomchyn DzmitryFomchyn merged commit e4590a8 into main Feb 28, 2024
39 of 43 checks passed
@DzmitryFomchyn DzmitryFomchyn deleted the df-adasis-nn-review branch February 28, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Should not be added into version changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants