Update MapboxDirections, Maps, and SDWebImage #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
force-pushed
the
fred-update-deps2
branch
2 times, most recently
from
ba6a7fa
to
04e984d
Compare
bsudekum
reviewed
Jan 19, 2018
| default: | ||
| self.arrowView.text = "⬆️" | ||
| } | ||
| let direction = step.maneuverDirection |
There was a problem hiding this comment.
This variable can be removed and you can just switch on step.maneuverDirection
bsudekum
approved these changes
Jan 19, 2018
frederoni
force-pushed
the
fred-update-deps2
branch
from
31d3fc5
to
910c49d
Compare
JThramer
approved these changes
Jan 19, 2018
| self.arrowView.text = "⬅️" | ||
| case .uTurn: | ||
| self.arrowView.text = "⤵️" | ||
| default: |
There was a problem hiding this comment.
There's a subtle edge-case behavioral change here -- if step.maneuverDirection = nil, the arrow text becomes "⬆️".
That may be desirable, I just thought i should point this out.
There was a problem hiding this comment.
Yes, I think that’s fine. Our other option is ⏹. 😉
1ec5
approved these changes
Jan 19, 2018
| @@ -40,7 +40,7 @@ Pod::Spec.new do |s| | |||
| s.requires_arc = true | |||
| s.module_name = "MapboxCoreNavigation" | |||
|
|
|||
| s.dependency "MapboxDirections.swift", "~> 0.15" | |||
| s.dependency "MapboxDirections.swift", "~> 0.16.0" | |||
There was a problem hiding this comment.
This was the problem: we were specifying only the minor version, so the tadpole operator would float until the next major version (1.0). By contrast, Carthage intentionally violates semver by being more strict pre-1.0.
There was a problem hiding this comment.
Maybe worth changing now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1039
We released a couple of breaking changes MapboxDirections.swift 0.16.0 which haven't been adopted in this library yet but CocoaPods decided pull in 0.16.0 even though we specify
~> 0.15unlike Carthage.@mapbox/navigation-ios 👀