New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MapboxDirections, Maps, and SDWebImage #1040
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" "3.7.1" | ||
binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" "3.7.3" | ||
github "ceeK/Solar" "2.1.0" | ||
github "facebook/ios-snapshot-test-case" "2.1.4" | ||
github "frederoni/aws-sdk-ios" "2.6.5" | ||
github "mapbox/MapboxDirections.swift" "v0.15.1" | ||
github "mapbox/MapboxDirections.swift" "v0.16.0" | ||
github "mapbox/mapbox-telemetry-ios" "v0.2.11" | ||
github "mapbox/turf-swift" "v0.0.4" | ||
github "raphaelmor/Polyline" "v4.2.0" | ||
github "rs/SDWebImage" "4.2.2" | ||
github "rs/SDWebImage" "4.2.3" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,7 +40,7 @@ Pod::Spec.new do |s| | |
s.requires_arc = true | ||
s.module_name = "MapboxCoreNavigation" | ||
|
||
s.dependency "MapboxDirections.swift", "~> 0.15" | ||
s.dependency "MapboxDirections.swift", "~> 0.16.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was the problem: we were specifying only the minor version, so the tadpole operator would float until the next major version (1.0). By contrast, Carthage intentionally violates semver by being more strict pre-1.0. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe worth changing now? |
||
s.dependency "MapboxMobileEvents", "~> 0.2" | ||
s.dependency "Turf", "~> 0.0.4" | ||
|
||
|
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a subtle edge-case behavioral change here -- if
step.maneuverDirection = nil
, the arrow text becomes "⬆️".That may be desirable, I just thought i should point this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that’s fine. Our other option is ⏹. 😉