Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show lane guidance in CarPlay guidance panel #1885

Closed
wants to merge 3 commits into from

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Dec 5, 2018

CarPlayNavigationViewController now snapshots a LanesView for display in the CarPlay guidance panel. The layout needs work: currently all the LaneViews are smooshed up against the upper-left corner of the LanesView, and they’re shown at full scale but cropped.

lanes

LanesView is the right size, but the stack view inside it seems to be missing constraints:

lanesview

Additionally, LaneView will need to be modified to accept alternative dimensions for the arrows.

Fixes #1858.

/cc @JThramer @frederoni

@1ec5 1ec5 added ⚠️ DO NOT MERGE PR should not be merged! feature New feature request. topic: instructions wip CarPlay Bugs, improvements and feature requests on Apple CarPlay labels Dec 5, 2018
@1ec5 1ec5 self-assigned this Dec 5, 2018
@frederoni
Copy link
Contributor

frederoni commented Dec 11, 2018

There was a missing width constraint when the LanesView isn't wrapped in a container view as you assumed.

The lane icons are not rendered pixel perfect, but the constraints seem to be correct now. It's tricky when Xcode’s view hierarchy debugger doesn't work with CarPlay. Not sure if the blurriness comes from the PaintCode assets being incorrectly scaled or .imageRepresentation using the incorrect scale. Also, I think there's a separator view we should hide when the LanesView is being used in CarPlay.

Do you think we need to update the lane view icons? Maneuver icons support both size and scale, but the lane views only support scale:

Actually, lane_slight_right is the only lane asset that support scale.

I can take a look at the PaintCode assets if necessary. Can you merge master into this branch in the meantime?

@1ec5
Copy link
Contributor Author

1ec5 commented Dec 13, 2018

Do you think we need to update the lane view icons? Maneuver icons support both size and scale, but the lane views only support scale:

That would be nice; the arrows end up looking pretty anemic at that size.

@1ec5 1ec5 removed the ⚠️ DO NOT MERGE PR should not be merged! label Dec 13, 2018
@1ec5
Copy link
Contributor Author

1ec5 commented Dec 18, 2018

Do you think we need to update the lane view icons? Maneuver icons support both size and scale, but the lane views only support scale

Would this be addressed by mapbox/navigation-ui-resources#7?

@frederoni
Copy link
Contributor

Would this be addressed by mapbox/navigation-ui-resources#7?

Good point. Testing these here #1910

@akitchen
Copy link
Contributor

Looks like this has gone stale. Can we revive it? It looks really promising.

@frederoni frederoni mentioned this pull request Jan 16, 2019
4 tasks
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 23, 2019

I’m also seeing lanes get dropped in some cases. A route from 39.287527°N, 84.462424°W to 39.290445°N, 84.467252°W traverses this way tagged turn:lanes=left|left|through|through|right|right, which is correctly interpreted by the Directions API, yet I only see four lane icons in the CarPlay UI:

carplay ios

I suspect that’s because we’re constraining the image to fit within the 120×18-point allowable image size. We should check whether that check is as strict for lane icons as it is for shields.

@1ec5
Copy link
Contributor Author

1ec5 commented Feb 6, 2021

Closing in favor of #2798.

@1ec5 1ec5 closed this Feb 6, 2021
@1ec5 1ec5 deleted the 1ec5-carplay-lanes-1858 branch October 1, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CarPlay Bugs, improvements and feature requests on Apple CarPlay feature New feature request. topic: instructions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show lane guidance in CarPlay maneuver panel
4 participants