-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show lane guidance in CarPlay guidance panel #1885
Conversation
baa53c5
to
a1286b5
Compare
That would be nice; the arrows end up looking pretty anemic at that size. |
a1286b5
to
fff431e
Compare
Would this be addressed by mapbox/navigation-ui-resources#7? |
Good point. Testing these here #1910 |
Looks like this has gone stale. Can we revive it? It looks really promising. |
fff431e
to
3184dd5
Compare
I’m also seeing lanes get dropped in some cases. A route from 39.287527°N, 84.462424°W to 39.290445°N, 84.467252°W traverses this way tagged I suspect that’s because we’re constraining the image to fit within the 120×18-point allowable image size. We should check whether that check is as strict for lane icons as it is for shields. |
Closing in favor of #2798. |
CarPlayNavigationViewController now snapshots a LanesView for display in the CarPlay guidance panel. The layout needs work: currently all the LaneViews are smooshed up against the upper-left corner of the LanesView, and they’re shown at full scale but cropped.
LanesView is the right size, but the stack view inside it seems to be missing constraints:
Additionally, LaneView will need to be modified to accept alternative dimensions for the arrows.
Fixes #1858.
/cc @JThramer @frederoni