-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to port building highlighting feature #2827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanMa1991
added
feature
New feature request.
UI
Work related to visual components, Android Auto, Camera, 3D, voice, etc.
iOS
labels
Feb 23, 2021
ShanMa1991
force-pushed
the
shan-highlighting-728
branch
from
March 1, 2021 19:54
6c6433f
to
b4d6e2d
Compare
MaximAlien
force-pushed
the
shan-highlighting-728
branch
from
March 2, 2021 23:12
b4d6e2d
to
e8305fc
Compare
MaximAlien
reviewed
Mar 2, 2021
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
ShanMa1991
force-pushed
the
shan-highlighting-728
branch
from
March 3, 2021 00:12
e8305fc
to
0f1f97d
Compare
MaximAlien
force-pushed
the
shan-highlighting-728
branch
from
March 3, 2021 17:50
7c83814
to
59532f1
Compare
MaximAlien
reviewed
Mar 3, 2021
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
MaximAlien
reviewed
Mar 3, 2021
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
ShanMa1991
force-pushed
the
shan-highlighting-728
branch
from
March 3, 2021 20:01
59532f1
to
1b33fa3
Compare
MaximAlien
reviewed
Mar 4, 2021
MaximAlien
reviewed
Mar 4, 2021
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
ShanMa1991
force-pushed
the
shan-highlighting-728
branch
from
March 4, 2021 21:39
d9dc162
to
6792c5d
Compare
MaximAlien
force-pushed
the
shan-highlighting-728
branch
from
March 4, 2021 23:59
6792c5d
to
bbd0735
Compare
MaximAlien
reviewed
Mar 5, 2021
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
MaximAlien
reviewed
Mar 5, 2021
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
MaximAlien
reviewed
Mar 5, 2021
MaximAlien
reviewed
Mar 5, 2021
MaximAlien
reviewed
Mar 5, 2021
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
MaximAlien
reviewed
Mar 5, 2021
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
MaximAlien
reviewed
Mar 5, 2021
Sources/MapboxNavigation/NavigationMapView+BuildingHighlighting.swift
Outdated
Show resolved
Hide resolved
ShanMa1991
force-pushed
the
shan-highlighting-728
branch
from
March 5, 2021 01:12
bbd0735
to
44682e3
Compare
MaximAlien
force-pushed
the
shan-highlighting-728
branch
from
March 5, 2021 23:31
7426003
to
c61b6a8
Compare
MaximAlien
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Please squash all existing commits before instead of merging all of them.
Suggested changelog entry:
|
Thanks for the suggestion, I'll update the changelog. |
ShanMa1991
force-pushed
the
shan-highlighting-728
branch
from
March 8, 2021 21:52
cbf8039
to
7b563fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pr is to add the ability to high light choose building after long press in 3D, solving the #728 The opacity would be varied with zoom level. The building would also appear in certain zoom level.
Implementation
Add the calling functions of
mapView.highlightBuildings(at:, in 3D:)
to highlight the chosen waypoint. Do query the feature at the waypoint on map view to find the id of the corresponding building. Then add one fillExtrusionLayer and filter the layer based on the building id.It would allow the building from 3D changing to 2D in
DayStyle
andNightStyle
. The color of building would also change from blue to red whenNightStyle
is chosen.Screenshots or Gifs
As the below .gif, it allow a series of long press to choose multiple buildings to highlight, the color of the building would change under different circumstances.
It also allow the end of route the puck located at the waypoint and change 3D to 2D, behavior same as the 1.x.