Fix route line visibility. #3205
Conversation
| @@ -153,8 +153,7 @@ extension NavigationMapView { | |||
| } | |||
| } | |||
|
|
|||
| func onViewDidAppear() { | |||
| showRouteIfNeeded() | |||
There was a problem hiding this comment.
Previous delegate method name was incorrect, so it was never called, not sure if we really need navigationViewDidAppear(_:) anyway. Call to showRouteIfNeeded() is not needed either as it'll be called each time MapView style changes.
| @@ -47,8 +47,8 @@ extension NavigationMapView { | |||
| // MARK: - Private methods | |||
|
|
|||
| private func showRouteIfNeeded() { | |||
| guard navigationViewData.containerViewController.isViewLoaded && | |||
| navigationViewData.containerViewController.view.window != nil else { return } | |||
There was a problem hiding this comment.
@Udumft, would you be able to provide more details on why you've added this check: navigationViewData.containerViewController.view.window != nil? At this point it prevents from showing route line right at the start of active guidance navigation session, when using NavigationViewController. I wonder if I miss anything here.
MaximAlien
force-pushed
the
maxim/update-dependencies
branch
from
b218c74
to
fefe858
Compare
MaximAlien
force-pushed
the
maxim/3193-fix-route-line-invisibility
branch
from
61fd00a
to
de38c92
Compare
MaximAlien
force-pushed
the
maxim/update-dependencies
branch
from
b0d35ba
to
96c8c3d
Compare
MaximAlien
force-pushed
the
maxim/3193-fix-route-line-invisibility
branch
2 times, most recently
from
a503e29
to
a6f6e8f
Compare
MaximAlien
force-pushed
the
maxim/update-dependencies
branch
from
96c8c3d
to
cb5b84f
Compare
MaximAlien
force-pushed
the
maxim/3193-fix-route-line-invisibility
branch
from
afcb804
to
665f177
Compare
| // Since `NavigationViewController` presents route line after its presentation it is expected | ||
| // that maneuver arrow stroke layer will be added above main route line layer. |
There was a problem hiding this comment.
Thanks for adding comments into the test code! That area of the code base would benefit from more in-line comments.
MaximAlien
force-pushed
the
maxim/update-dependencies
branch
from
1b5fce4
to
4bc1f75
Compare
MaximAlien
force-pushed
the
maxim/3193-fix-route-line-invisibility
branch
from
665f177
to
1d538aa
Compare
…ontroller` instance.
MaximAlien
force-pushed
the
maxim/3193-fix-route-line-invisibility
branch
from
85feb0b
to
baf7b9d
Compare
Description
Closing #3193.