Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actively remove parens from voice instructions #418

Merged
merged 4 commits into from
Jul 25, 2017
Merged

Actively remove parens from voice instructions #418

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c95209
Actively remove parens from voice instructions
Jul 24, 2017
2351faa
No space
Jul 24, 2017
ec2cedc
move to own func
Jul 25, 2017
9937c0b
Change name
Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion MapboxNavigation/String.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ extension String {
("&", "&"),
("<", "&lt;"),
("\"", "&quot;"),
("'", "&apos;")
("'", "&apos;"),
("(", ""),
(")", "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This turns addingXMLEscapes into a misnomer. This method may be used in places where we just want to mark up XML and don’t want to remove parentheses. Instead of repurposing this method, let’s modify the call sites to remove parentheses.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along the lines of osmlab/osmlint#234, are there any other characters that we should strip out?

])
}
}