Localize map labels into user-preferred languages #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The application’s UI language is irrelevant to whether the map should be localized into a language that the user says they prefer in Settings.
MaximAlien
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the
NavigationMapView.localizeLabels()method only localized map labels according to the user’s Preferred Language Order setting if the application also had a localization in the preferred language. The application’s UI language is irrelevant to whether the map should be localized into a language that the user says they prefer.This change won’t be a problem for backwards compatibility: the method’s documentation comment says it honors the preference and doesn’t mention anything about the preference being constrained to the application bundle’s languages.
Fixes #4190.
/cc @mapbox/navigation-ios