-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
…ent implementation but might introduce it again
@isiyu @MateoV @brnkhy @david-rhodes @parahunter Could I get some 👀 from you guys. This should bring in the first iteration of threaded tile fetching. Tests work locally but fail on AppVeyor - looking into this right now. |
Forgot to mention above: already merged master into this branch so merging should cause no troubles. |
Ok, AppVeyor ✅ I introduced |
@BergWerkGIS What should we specifically be looking for? I think a lot of stuff has changed here? |
@david-rhodes I was thinking about a general review before merging. |
@BergWerkGIS Here are some of my notes:
Some of these are general notes for SDK, and not this PR, specifically. I'm fine merging this now just to keep things moving, however. |
@david-rhodes thanks for taking a look.
Of course we can/want to make further changes - this is just the first iteration of getting threading into our sdk. My idea was to keep the user away from actual tile fetching as much as possible: I started reworking (far from finished) the
I guess that's obsolete now as the Going to look into integrating threading with
That's exactly what I thought to put into @
@david-rhodes Care to explain the If one wants more control over when tiles are fetched there are:
Already had it in there, but I wasn't able to spot any differences so I removed it.
Sort of (partly) implemented via MemoryCache.
🎉 🎉 🎉 |
This is true, but we can't assume everyone will use
Say a developer wants to change I would prefer something like: _map.Zoom = 15;
_map.MapId = "something";
_map.DownloadTiles(); But I guess this is the same as: _map.DisableTileDownloading();
_map.Zoom = 15;
_map.MapId = "something";
_map.EnableTileDownloading(); I'll get back to this regarding object pooling. |
Did some more memory profiling of the threading code (no Unity involved) and wasn't able to spot any major leaks. Nevertheless I should spend some time on VectorTileCs #13 ( That's the code I used for profiling (it's self contained - no references to other repos or nuget etc., latest DLLs of this branch already included): --> mapbox-sdk-unity-core-profile-threading-master.zip In case anyone wants access to the repo - ping me. |
Bring multithreaded tile fetching back into core