Skip to content
This repository has been archived by the owner on Nov 25, 2019. It is now read-only.

preparing 'mapbox-sdk-unity-core' to become 'mapbox-sdk-cs' #48

Merged
merged 11 commits into from
Feb 20, 2017

Conversation

wilhelmberg
Copy link
Contributor

@wilhelmberg wilhelmberg self-assigned this Feb 7, 2017
@david-rhodes
Copy link
Contributor

LGTM. Why are checks failing?

@wilhelmberg
Copy link
Contributor Author

LGTM. Why are checks failing?

hm, they weren't before.
I'll check. Suppose #43 (color conversion) should have been merged before this PR not after.

@wilhelmberg
Copy link
Contributor Author

Removed more references to Unity.

Already published a nupkg (although internal structure will most likely change during repos reboot):
https://www.nuget.org/packages/MapboxSdkCs/

@isiyu what was your Microsoft ID again - so I can add to as owner on nuget.org?

AppVeyor is ✅: https://ci.appveyor.com/project/Mapbox/mapbox-sdk-unity-core/build/1.0.186

We should make sure everything Unity related is already carried over to mapbox-sdk-unity before merging.
Eg functions removed from Util/Conversions.cs
Who's taking care of that?


Todo after repo renaming: #49

@MateoV
Copy link
Contributor

MateoV commented Feb 13, 2017

This is on me now. Porting the conversions to the main sdk today, then plan to rename the script here and clean up any straggling references and unused vars.

@isiyu
Copy link
Contributor

isiyu commented Feb 13, 2017

@BergWerkGIS - my windows login is iseeyou7787@hotmail.com

@wilhelmberg
Copy link
Contributor Author

AppVeyor ✅ https://ci.appveyor.com/project/Mapbox/mapbox-sdk-unity-core/build/1.0.197/tests

From my point of view we are ready to merge and rename the repo.

@MateoV MateoV merged commit 0ffae23 into master Feb 20, 2017
@MateoV MateoV deleted the mapbox-sdk-cs branch February 20, 2017 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants