Drop the dataset batch endpoint #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcwhittemore
force-pushed
the
drop-batch-dataset-write
branch
from
5baaecf
to
6b6075f
Compare
mcwhittemore
force-pushed
the
drop-batch-dataset-write
branch
from
5f15140
to
d0910ad
Compare
scothis
reviewed
Oct 19, 2016
| @@ -1,3 +1,9 @@ | |||
| ## 1.0.0.beta4 | |||
| owner: this.owner | ||
| }, | ||
| callback: callback | ||
| }).entity(); | ||
| }); |
There was a problem hiding this comment.
Curious if @tmcw has any concern about dropping .entity().
|
@scothis do you think the promise response should match the callback response object? |
|
Yes, the callback and promise should hold the same value. |
mcwhittemore
force-pushed
the
drop-batch-dataset-write
branch
2 times, most recently
from
562fdee
to
d7041a3
Compare
|
@scothis - ok, I think this is ready now. |
scothis
reviewed
Oct 19, 2016
| function transform(response) { | ||
| return { | ||
| url: response.url, | ||
| status: response.status.code, |
There was a problem hiding this comment.
It's possible some errors may not have a status object.
| @@ -1,3 +1,10 @@ | |||
| ## 1.0.0 | |||
There was a problem hiding this comment.
IDK? We've been on beta a few times now. In an earlier commit, I called this beta4. I can go back to that if you like.
What is our goal with 1.0?
mcwhittemore
force-pushed
the
drop-batch-dataset-write
branch
from
98f34eb
to
40d2c22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we look to move the dataset api past beta we have decided that that batch api is not something we plan to support for the long term.
This PR drops support of it fully rather than converting the batch functionality to use the single feature put and delete endpoints.
@scothis for the review