Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for checking undesirable dependencies in resolved file #133

Open
5 tasks
IodaMikeMapbox opened this issue Jun 14, 2019 · 0 comments
Open
5 tasks
Labels
iOS nostale ignored by stalebot P1 Good to have

Comments

@IodaMikeMapbox
Copy link
Contributor

Summary

Carthage.resolved could contain dependencies which were used to build project by carthage.
We can write a script which will check such kind of dependencies and run it in CI.

List of projects:

  • vision-ios-examples;
  • mapbox-vision-ios/Examples;
  • mapbox-vision-devtools/Platforms/iOS/DataRecorder.

List of undesirable dependencies in resolved:

  • github "mapbox/mapbox-vision-ios" – presence of this dependency in resolved breaks bootstrap script;
  • binary "https://api.mapbox.com/downloads/v1/vision/ios/mapbox-vision-native-all.carthage?access_token=<TOKEN>" – potential leak of private token.

Steps

  • Implement script;
  • Add script to CI:
    • mapbox-vision-ios;
    • vision-ios-examples;
    • mapbox-vision-devtools.
@IodaMikeMapbox IodaMikeMapbox added iOS P1 Good to have labels Jun 14, 2019
@vladzima vladzima added the nostale ignored by stalebot label Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS nostale ignored by stalebot P1 Good to have
Projects
None yet
Development

No branches or pull requests

2 participants