Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol map support #149

Closed
wants to merge 1 commit into from
Closed

Conversation

akacarlyann
Copy link
Collaborator

@akacarlyann akacarlyann commented Mar 15, 2019

Added a demo for a symbol map using icons defined using URLs. @ryanbaumann were you thinking symbol map would make use of the Maki library or is this in the right direction?

To do:

  • symbol legend
  • custom symbol url property name
  • symbol size controls
  • Maki symbol support?

Addresses #4

@ryanbaumann
Copy link
Contributor

ryanbaumann commented Mar 19, 2019

Thanks for taking a stab at this @akacarlyann - I would suggest we use the map.addImage() function to add symbols to the map style for performance reasons (map.addImage uses the sprite sheet to render images into the GL context) over HTML markers (which render on top of the map GL context). https://docs.mapbox.com/mapbox-gl-js/example/add-image/

Support for default maki icons in symbol maps would be a good batteries-included feature for data visualizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants