Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual comparisons instead of geojson text comparisons #205

Open
springmeyer opened this issue Apr 19, 2016 · 1 comment
Open

Visual comparisons instead of geojson text comparisons #205

springmeyer opened this issue Apr 19, 2016 · 1 comment

Comments

@springmeyer
Copy link
Contributor

springmeyer commented Apr 19, 2016

We need to add support for visual comparisons of changes in geometry outputs. Minor changes in floating point differences currently trigger the need for massive updates to the test fixtures like mapnik/geometry-test-data@65abcf0 which is dangerous because:

  • The diff is way to big for github to show
  • Meaningful changes can too easily go unnoticed.

A visual approach (rendered png) would make it viable to review all the changes efficiently rather than just hope for the best.

@pnorman
Copy link
Contributor

pnorman commented Apr 19, 2016

pretty printing the json might also help, it would mean that when one value changes you can get a more meaningful diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants