Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data team peer review 7/11-7/15 #212

Closed
karitotp opened this issue Jul 19, 2016 · 31 comments
Closed

Data team peer review 7/11-7/15 #212

karitotp opened this issue Jul 19, 2016 · 31 comments

Comments

@karitotp
Copy link

Last peer review ticket: #209

Mapping projects to be reviewed:

  1. Exit and Destination Mapping
  2. Turn restriction validation
  3. To Fix tasks

Instructions

  • Download .osm files for last week.
  • Extract the tar file and select any OSM file of the team member.
  • Each team member will have an .osm file of edits for the last seven days. For example: latest-andygol.osm. Select any .osm file and open the data in JOSM.
  • If you don't find any osm file of a particular team member, then it means that user has not edited during the week.
  • Examine user edits in detail. In JOSM, select a random small area edited by the user and press 3 to zoom.
  • Download the latest data in OSM as a new layer and add a filter Cmd + F to see only the user's edits, e.g. user:andygol.

andyfilter3

  • Select a way/node and load the the history (Ctrl + H), the changeset comment will describe what specific project the user was working on.
  • To get an OSM link to the object, click Cmd + Shift + H.
  • Note down any feedback for each user in this ticket or comment directly in the changeset. Use this format:
username
changeset link - issue to fix
  • @krishnanammala @chtnha or @karitotp will post the feedback in the ticket (Use Github handle because OSM name is different from Github name) and make necessary changes on the same day.
  • Close the ticket once user's have fixed their edits.

For clarifications, discuss with the @mapbox/team-data in this ticket.

@karitotp
Copy link
Author

@piligab

waterway=river have layer=-1

https://www.openstreetmap.org/way/199118459
https://www.openstreetmap.org/way/162557505
https://www.openstreetmap.org/way/371701610
https://www.openstreetmap.org/way/231193420

Not tunnel and bridge together

https://www.openstreetmap.org/way/231193420
https://www.openstreetmap.org/way/103304805
https://www.openstreetmap.org/way/430617084
https://www.openstreetmap.org/way/194737923
https://www.openstreetmap.org/way/139855290
https://www.openstreetmap.org/way/393648836
https://www.openstreetmap.org/way/316440620
https://www.openstreetmap.org/way/422639783
https://www.openstreetmap.org/way/418666248
https://www.openstreetmap.org/way/418666268
https://www.openstreetmap.org/way/370426143
https://www.openstreetmap.org/way/370426154
https://www.openstreetmap.org/way/54400172
https://www.openstreetmap.org/way/415247990

Not tracing in polygons, improve the street

https://www.openstreetmap.org/way/191157693

Incorrect starting or ending of the tunnel

https://www.openstreetmap.org/way/381805234
https://www.openstreetmap.org/way/141893316

Not bridge

https://www.openstreetmap.org/way/166047045
https://www.openstreetmap.org/way/325985054
https://www.openstreetmap.org/way/112660219
https://www.openstreetmap.org/way/209338686
https://www.openstreetmap.org/way/165395423
https://www.openstreetmap.org/way/111788433
https://www.openstreetmap.org/way/108425882
https://www.openstreetmap.org/way/5317278

Doesn't work if satellite imagery isn't clear

https://www.openstreetmap.org/way/155445012
https://www.openstreetmap.org/way/353662187
https://www.openstreetmap.org/way/329134745
https://www.openstreetmap.org/way/271682590
https://www.openstreetmap.org/way/235479987
https://www.openstreetmap.org/way/293094141

Improve the street

https://www.openstreetmap.org/way/430431525
https://www.openstreetmap.org/way/430431526
https://www.openstreetmap.org/way/430431526
https://www.openstreetmap.org/way/430431527
https://www.openstreetmap.org/way/430431532
https://www.openstreetmap.org/way/430431524
https://www.openstreetmap.org/way/20655834

Crossing building

https://www.openstreetmap.org/way/402623064
https://www.openstreetmap.org/way/402620790
https://www.openstreetmap.org/way/402445577

Overlapping highways

https://www.openstreetmap.org/way/353720484

Add layer -1

https://www.openstreetmap.org/way/66672519

@karitotp
Copy link
Author

@ridixcr

Not tunnel and bridge together

https://www.openstreetmap.org/way/283018590
https://www.openstreetmap.org/way/154202815
https://www.openstreetmap.org/way/219350780

Duplicated ways

https://www.openstreetmap.org/way/430444296
https://www.openstreetmap.org/way/430444294
https://www.openstreetmap.org/way/430444308
https://www.openstreetmap.org/way/430441464
https://www.openstreetmap.org/way/430443389
https://www.openstreetmap.org/way/430419189

Doesn't work if satellite imagery isn't clear

https://www.openstreetmap.org/way/171851875
https://www.openstreetmap.org/way/430438912
https://www.openstreetmap.org/way/430438913
https://www.openstreetmap.org/way/430438347
https://www.openstreetmap.org/way/430438900
https://www.openstreetmap.org/way/328674838
https://www.openstreetmap.org/way/24044772
https://www.openstreetmap.org/way/70864498

Not tunnel

https://www.openstreetmap.org/way/382302259

Incorrect starting or ending of the tunnel

https://www.openstreetmap.org/way/160615514
https://www.openstreetmap.org/way/160615517

Incorrect starting or ending of the tunnel

https://www.openstreetmap.org/way/69738515

Crossing ways

https://www.openstreetmap.org/way/430444324
https://www.openstreetmap.org/way/402795392
https://www.openstreetmap.org/way/430421176
https://www.openstreetmap.org/way/430421186
https://www.openstreetmap.org/way/430422804
https://www.openstreetmap.org/way/430439451
https://www.openstreetmap.org/way/430441620
https://www.openstreetmap.org/way/40778339
https://www.openstreetmap.org/way/377171170
https://www.openstreetmap.org/way/430434490
https://www.openstreetmap.org/way/430428513
https://www.openstreetmap.org/way/430428369
https://www.openstreetmap.org/way/430425704
https://www.openstreetmap.org/way/51570998
https://www.openstreetmap.org/way/430441619
https://www.openstreetmap.org/way/397597669
https://www.openstreetmap.org/way/397597669
https://www.openstreetmap.org/way/389360826

Crossing buildings

https://www.openstreetmap.org/way/402636947
https://www.openstreetmap.org/way/402638922
https://www.openstreetmap.org/way/402445015

Overlapping highways

https://www.openstreetmap.org/way/430439028
https://www.openstreetmap.org/way/392207260
https://www.openstreetmap.org/way/430439029
https://www.openstreetmap.org/way/430439020
https://www.openstreetmap.org/way/392207262
https://www.openstreetmap.org/way/430420380
https://www.openstreetmap.org/way/430420376
https://www.openstreetmap.org/way/430420386
https://www.openstreetmap.org/way/430420375
https://www.openstreetmap.org/way/430430028
https://www.openstreetmap.org/way/430427495
https://www.openstreetmap.org/way/430427490
https://www.openstreetmap.org/way/430439527
https://www.openstreetmap.org/way/309420677
https://www.openstreetmap.org/way/430423261
https://www.openstreetmap.org/way/430439299
https://www.openstreetmap.org/way/430426277
https://www.openstreetmap.org/way/223902982

Unclosed buildings

https://www.openstreetmap.org/way/402594191
https://www.openstreetmap.org/way/402700557
https://www.openstreetmap.org/way/402640203
https://www.openstreetmap.org/way/201072222

Untagged way

https://www.openstreetmap.org/way/303247167
https://www.openstreetmap.org/way/417967598

Not bridge

https://www.openstreetmap.org/way/118121300
https://www.openstreetmap.org/way/124022341
https://www.openstreetmap.org/way/114280387
https://www.openstreetmap.org/way/254797441
https://www.openstreetmap.org/way/112780623
https://www.openstreetmap.org/way/112780623
https://www.openstreetmap.org/way/117151728
https://www.openstreetmap.org/way/116557606
https://www.openstreetmap.org/way/103752957
https://www.openstreetmap.org/way/251990944
https://www.openstreetmap.org/way/76536022
https://www.openstreetmap.org/way/152921979
https://www.openstreetmap.org/way/187299696
https://www.openstreetmap.org/way/132898200

@karitotp
Copy link
Author

@karitotp
Copy link
Author

@karitotp
Copy link
Author

@karitotp

Crossing ways

https://www.openstreetmap.org/way/202350780

Separate brigde the landuse=reservoir

https://www.openstreetmap.org/way/340379622

Overlapping highways

https://www.openstreetmap.org/way/430431521
https://www.openstreetmap.org/way/413067979
https://www.openstreetmap.org/way/430417043 - also review at side
https://www.openstreetmap.org/way/123233329 - guided with this node https://www.openstreetmap.org/node/1374961572
https://www.openstreetmap.org/way/249323294
https://www.openstreetmap.org/way/430444271

Add bridge and layer

https://www.openstreetmap.org/way/306324113
https://www.openstreetmap.org/way/334955086 - guided with this node https://www.openstreetmap.org/node/414929168
https://www.openstreetmap.org/way/179985594 - guided with this node https://www.openstreetmap.org/node/1904320328
https://www.openstreetmap.org/way/361311478 - guided with this node https://www.openstreetmap.org/node/3658044151

Self intersecting highways

https://www.openstreetmap.org/way/125266574
https://www.openstreetmap.org/way/31040170
https://www.openstreetmap.org/way/209443089
https://www.openstreetmap.org/way/406232069
https://www.openstreetmap.org/way/171298669
https://www.openstreetmap.org/way/16608914

Add layer

https://www.openstreetmap.org/way/275478437

Crossing buildings

https://www.openstreetmap.org/way/402593864

Improve way

https://www.openstreetmap.org/way/149729859
https://www.openstreetmap.org/way/128637211

combine buildings

https://www.openstreetmap.org/way/402593117

@karitotp
Copy link
Author

@calfarome

Overlapping highways

https://www.openstreetmap.org/way/338223895

Split the bridge

https://www.openstreetmap.org/way/44168695

Bridge and Tunnel together

https://www.openstreetmap.org/way/301666406

Delete bridge tag

https://www.openstreetmap.org/way/5659866
https://www.openstreetmap.org/way/102490580

Delete bridge tag and add tunnel=culvert to the stream

https://www.openstreetmap.org/way/294686437
https://www.openstreetmap.org/way/183003857
https://www.openstreetmap.org/way/161884161
https://www.openstreetmap.org/way/51696205
https://www.openstreetmap.org/way/205889696

Delete bridge tag and add tunnel=yes to the highway

https://www.openstreetmap.org/way/100492951

Use bridge=covered instead of bridge=yes

https://www.openstreetmap.org/way/195179733

Split and join highways based on the direction

https://www.openstreetmap.org/way/271950683 (all services around)

Split highway

https://www.openstreetmap.org/way/361991902
https://www.openstreetmap.org/way/295436096
https://www.openstreetmap.org/way/190545870

Wrong turn:lanes value

https://www.openstreetmap.org/way/359612958
https://www.openstreetmap.org/way/229928636 (split the way)
https://www.openstreetmap.org/way/364967170
https://www.openstreetmap.org/way/430390511
https://www.openstreetmap.org/way/415803412
https://www.openstreetmap.org/way/427891397

Wrong starting of turn:lanes

https://www.openstreetmap.org/way/397514357
https://www.openstreetmap.org/way/307512528
https://www.openstreetmap.org/way/398059555
https://www.openstreetmap.org/way/398061564
https://www.openstreetmap.org/way/398061568

@karitotp
Copy link
Author

@RichRico

Bridge tag and layer tag are incorrect - tunnel and bridge together

https://www.openstreetmap.org/way/176332835

Unnecessary tunnel because there are bridges

https://www.openstreetmap.org/way/136829162

Not work if satellite imagery isn't clear

https://www.openstreetmap.org/way/190142324

Unclosed Building

https://www.openstreetmap.org/way/402637273
https://www.openstreetmap.org/way/431047794
https://www.openstreetmap.org/way/232134241
https://www.openstreetmap.org/way/402478234

Wrong starting tunr:lanes

https://www.openstreetmap.org/way/428491174

Wrong lanes number turn:lanes forward

https://www.openstreetmap.org/way/401425193

Wrong tagging turn:lanes and missing turn:lanes along the street

https://www.openstreetmap.org/way/347631717

Split the highway

https://www.openstreetmap.org/way/430418454
https://www.openstreetmap.org/way/430425025
https://www.openstreetmap.org/way/223577358
https://www.openstreetmap.org/way/106107160
https://www.openstreetmap.org/way/156646832
https://www.openstreetmap.org/way/412747709
https://www.openstreetmap.org/way/326010935
https://www.openstreetmap.org/way/406338506
https://www.openstreetmap.org/way/370270167
https://www.openstreetmap.org/way/300416653
https://www.openstreetmap.org/way/300416653
https://www.openstreetmap.org/way/430438706 - review around
https://www.openstreetmap.org/way/85888691
https://www.openstreetmap.org/way/353919641
https://www.openstreetmap.org/way/399569501
https://www.openstreetmap.org/way/275895275
https://www.openstreetmap.org/way/77445323
https://www.openstreetmap.org/way/430420361 - review around
https://www.openstreetmap.org/way/379491700
https://www.openstreetmap.org/way/430432404
https://www.openstreetmap.org/way/280337937
https://www.openstreetmap.org/way/8911411
https://www.openstreetmap.org/way/176253000 - review around
https://www.openstreetmap.org/way/430444826 - review around
https://www.openstreetmap.org/way/381864650
https://www.openstreetmap.org/way/430445205
https://www.openstreetmap.org/way/24077893
https://www.openstreetmap.org/way/359991164
https://www.openstreetmap.org/way/176253000
https://www.openstreetmap.org/way/9618536
https://www.openstreetmap.org/way/5322447
https://www.openstreetmap.org/way/222346086
https://www.openstreetmap.org/way/156646832
https://www.openstreetmap.org/way/113540598
https://www.openstreetmap.org/way/60754876
https://www.openstreetmap.org/way/195444712

Add layer=1

https://www.openstreetmap.org/way/125128691

@karitotp
Copy link
Author

@Rub21

Remove landuse tag

https://www.openstreetmap.org/way/322424329

@karitotp
Copy link
Author

@maanyaumashaanker

Crossing building - Change your OSM user for the import of buildings

https://www.openstreetmap.org/way/430933346
https://www.openstreetmap.org/way/430933155

@karitotp
Copy link
Author

@planemad

Together buildings

https://www.openstreetmap.org/way/431118630/history
https://www.openstreetmap.org/way/431118778/history
https://www.openstreetmap.org/way/431119009/history
https://www.openstreetmap.org/way/431118694/history
https://www.openstreetmap.org/way/431117451/history
https://www.openstreetmap.org/way/431117475/history
https://www.openstreetmap.org/way/431117513/history
https://www.openstreetmap.org/way/431117591/history
https://www.openstreetmap.org/way/431117122/history
https://www.openstreetmap.org/way/431117435/history
https://www.openstreetmap.org/way/431115943/history
https://www.openstreetmap.org/way/431116255/history
https://www.openstreetmap.org/way/431116204/history
https://www.openstreetmap.org/way/431116115/history
https://www.openstreetmap.org/way/431115621/history
https://www.openstreetmap.org/way/431117448/history
https://www.openstreetmap.org/way/431117390/history
https://www.openstreetmap.org/way/430966656/history
https://www.openstreetmap.org/way/430966309/history
https://www.openstreetmap.org/way/430781763/history
https://www.openstreetmap.org/way/430781264/history
https://www.openstreetmap.org/way/430781746/history
https://www.openstreetmap.org/way/430781717/history
https://www.openstreetmap.org/way/430781808/history
https://www.openstreetmap.org/way/430781944/history
https://www.openstreetmap.org/way/430781831/history
https://www.openstreetmap.org/way/430781911/history
https://www.openstreetmap.org/way/430781765/history
https://www.openstreetmap.org/way/430782057/history
https://www.openstreetmap.org/way/430781827/history
https://www.openstreetmap.org/way/430781795/history
https://www.openstreetmap.org/way/430781785/history
https://www.openstreetmap.org/way/430782009/history
https://www.openstreetmap.org/way/430781744/history

Incorrectly building

https://www.openstreetmap.org/way/431118327/history

@karitotp
Copy link
Author

karitotp commented Jul 21, 2016

Thanks for the feedback team!!

Crossing ways

https://www.openstreetmap.org/changeset/40664264

Separate brigde the landuse=reservoir

https://www.openstreetmap.org/way/340379622 - not an error

Overlapping highways

https://www.openstreetmap.org/changeset/40910904
https://www.openstreetmap.org/changeset/40910978
https://www.openstreetmap.org/changeset/40910992
https://www.openstreetmap.org/changeset/40911032
https://www.openstreetmap.org/changeset/40911055

Add bridge and layer

https://www.openstreetmap.org/changeset/40911094
https://www.openstreetmap.org/changeset/40911144
https://www.openstreetmap.org/changeset/40911174 - fixed, but isn't an error according to the changeset's comment
https://www.openstreetmap.org/node/3658044151 - The bridge does not exist in the satellite imagery

Self intersecting highways

https://www.openstreetmap.org/changeset/40911221
https://www.openstreetmap.org/way/31040170 - the edition does not match with the satellite imagery
https://www.openstreetmap.org/changeset/40911293
https://www.openstreetmap.org/changeset/40911319
https://www.openstreetmap.org/changeset/40911351- fixed, but isn't an error according to the changeset's comment
https://www.openstreetmap.org/changeset/40911374

Add layer

https://www.openstreetmap.org/way/275478437 - not an error

Crossing buildings

https://www.openstreetmap.org/changeset/40910773

Improve way

https://www.openstreetmap.org/way/149729859
https://www.openstreetmap.org/way/128637211
According to the changeset's comment, it isn't an error.

combine buildings

https://www.openstreetmap.org/changeset/40911398

@RichRico
Copy link

RichRico commented Jul 21, 2016

Thanks for the feedback

Bridge tag and layer tag are incorrect - tunnel and bridge together

https://www.openstreetmap.org/changeset/40923125

Unnecessary tunnel because there are bridges

https://www.openstreetmap.org/changeset/40923161

Not work if satellite imagery isn't clear

https://www.openstreetmap.org/way/190142324 not an error

Split the highway

https://www.openstreetmap.org/changeset/40923461
https://www.openstreetmap.org/changeset/40923507
https://www.openstreetmap.org/changeset/40923520
https://www.openstreetmap.org/changeset/40923537
https://www.openstreetmap.org/changeset/40923548
https://www.openstreetmap.org/changeset/40923565
https://www.openstreetmap.org/changeset/40923579
https://www.openstreetmap.org/changeset/40923591
https://www.openstreetmap.org/way/370270167 not an error
https://www.openstreetmap.org/changeset/40923648
https://www.openstreetmap.org/way/300416653
https://www.openstreetmap.org/changeset/40923666
https://www.openstreetmap.org/changeset/40923695
https://www.openstreetmap.org/way/85888691 not an error
https://www.openstreetmap.org/changeset/40923727
https://www.openstreetmap.org/changeset/40668259
https://www.openstreetmap.org/way/77445323 not an error
https://www.openstreetmap.org/changeset/40923872
https://www.openstreetmap.org/changeset/40923905
https://www.openstreetmap.org/way/430432404 not an error
https://www.openstreetmap.org/changeset/40693846
https://www.openstreetmap.org/changeset/40668325
https://www.openstreetmap.org/changeset/40924069
https://www.openstreetmap.org/changeset/40924096
https://www.openstreetmap.org/way/381864650 not an error
https://www.openstreetmap.org/way/430445205 not an error
https://www.openstreetmap.org/way/24077893 not an error
https://www.openstreetmap.org/changeset/40924176
https://www.openstreetmap.org/way/176253000 not an error
https://www.openstreetmap.org/changeset/40924206
https://www.openstreetmap.org/way/5322447 not an error
https://www.openstreetmap.org/way/222346086 not an error
https://www.openstreetmap.org/way/156646832 not an error
https://www.openstreetmap.org/changeset/40924430
https://www.openstreetmap.org/changeset/40692145
https://www.openstreetmap.org/changeset/40924476

Add layer=1

https://www.openstreetmap.org/changeset/40696790 the solution was to remove the bridge

@piligab
Copy link

piligab commented Jul 21, 2016

Thanks for the feedback team.

waterway=river have layer=-1

Not tunnel and bridge together

Not tracing in polygons, improve the street

Incorrect starting or ending of the tunnel

Not bridge

-https://www.openstreetmap.org/changeset/40923459

Doesn't work if satellite imagery isn't clear

Improve the street

Crossing building

Overlapping highways

https://www.openstreetmap.org/way/353720484 not is an error

Add layer -1

@Rub21
Copy link
Contributor

Rub21 commented Jul 21, 2016

@Rub21

Remove landuse tag

https://www.openstreetmap.org/way/322424329

According : http://wiki.openstreetmap.org/wiki/Tag:landuse%3Dresidential

landuse=residential: An area of land dedicated to, or having predominantly residential buildings such as houses or apartment buildings.

According : http://wiki.openstreetmap.org/wiki/Tag:barrier%3Dfence

barrier=fence : This tag may be used either on a way or on a closed way.

We should remove it.

@manoharuss
Copy link
Contributor

Thank you for the feedback @karitotp

Corrected this building
https://www.openstreetmap.org/way/345524128

Improved this building
https://www.openstreetmap.org/way/431051350

@ridixcr
Copy link

ridixcr commented Jul 22, 2016

Thank you for the feedback team!!!

Not tunnel and bridge together

https://www.openstreetmap.org/changeset/40951191
https://www.openstreetmap.org/changeset/40951221
https://www.openstreetmap.org/changeset/40951241

Duplicated ways

https://www.openstreetmap.org/changeset/40668562
https://www.openstreetmap.org/changeset/40668562
https://www.openstreetmap.org/changeset/40951371
https://www.openstreetmap.org/way/430441464 - not error
https://www.openstreetmap.org/changeset/40668477
https://www.openstreetmap.org/changeset/40664730

Doesn't work if satellite imagery isn't clear

https://www.openstreetmap.org/way/171851875
https://www.openstreetmap.org/way/430438912
https://www.openstreetmap.org/way/430438913
https://www.openstreetmap.org/way/430438347
https://www.openstreetmap.org/way/430438900
https://www.openstreetmap.org/way/328674838
https://www.openstreetmap.org/way/24044772
https://www.openstreetmap.org/way/70864498

Not tunnel

https://www.openstreetmap.org/changeset/40951597

Incorrect starting or ending of the tunnel

https://www.openstreetmap.org/changeset/40951645
https://www.openstreetmap.org/changeset/40697362

Crossing ways

https://www.openstreetmap.org/way/430444324 - not error
https://www.openstreetmap.org/way/402795392 - not error
https://www.openstreetmap.org/way/430421176 - not error
https://www.openstreetmap.org/way/430421186 - not error
https://www.openstreetmap.org/way/430422804 - not error
https://www.openstreetmap.org/way/430439451 - not error
https://www.openstreetmap.org/way/430441620 - not error
https://www.openstreetmap.org/way/40778339 - not error
https://www.openstreetmap.org/changeset/40952072
https://www.openstreetmap.org/changeset/40952122
https://www.openstreetmap.org/changeset/40666100
https://www.openstreetmap.org/way/430428369 - not error
https://www.openstreetmap.org/changeset/40952241
https://www.openstreetmap.org/way/51570998 - not error
https://www.openstreetmap.org/way/430441619 - not error
https://www.openstreetmap.org/changeset/40952348
https://www.openstreetmap.org/way/389360826 - not error

Crossing buildings

https://www.openstreetmap.org/changeset/40952467
https://www.openstreetmap.org/changeset/40718778

Overlapping highways

https://www.openstreetmap.org/changeset/40667706
https://www.openstreetmap.org/changeset/40667706
https://www.openstreetmap.org/changeset/40667706
https://www.openstreetmap.org/way/430439020 - not error
https://www.openstreetmap.org/changeset/40667706
https://www.openstreetmap.org/way/430420380 - not error
https://www.openstreetmap.org/way/430420376 - not error
https://www.openstreetmap.org/way/430420386 - not error
https://www.openstreetmap.org/changeset/40665019
https://www.openstreetmap.org/way/430430028 - not error
https://www.openstreetmap.org/changeset/40954135
https://www.openstreetmap.org/way/430427490 - not error
https://www.openstreetmap.org/changeset/40667868
https://www.openstreetmap.org/changeset/40954216
https://www.openstreetmap.org/way/430423261 - not error
https://www.openstreetmap.org/changeset/40954271
https://www.openstreetmap.org/changeset/40665879
https://www.openstreetmap.org/changeset/40954566

Unclosed buildings

https://www.openstreetmap.org/changeset/40954647
https://www.openstreetmap.org/changeset/40954669
https://www.openstreetmap.org/changeset/40954709
https://www.openstreetmap.org/changeset/40954837

Untagged way

https://www.openstreetmap.org/way/303247167 - not error
https://www.openstreetmap.org/way/417967598 - not error

Not bridge

https://www.openstreetmap.org/changeset/40954973
https://www.openstreetmap.org/changeset/40955010
https://www.openstreetmap.org/way/114280387 - not error
https://www.openstreetmap.org/way/254797441 - not error
https://www.openstreetmap.org/changeset/40955075
https://www.openstreetmap.org/way/117151728 - not error
https://www.openstreetmap.org/way/116557606 - not error
https://www.openstreetmap.org/changeset/40955143
https://www.openstreetmap.org/way/251990944 - not error
https://www.openstreetmap.org/changeset/40955216
https://www.openstreetmap.org/way/152921979 - not error
https://www.openstreetmap.org/way/187299696 - not error
https://www.openstreetmap.org/way/132898200 - not error

@calfarome
Copy link

Thank you for the feedback team.

Overlapping highways

https://www.openstreetmap.org/way/338223895 (fixed)

Split the bridge

https://www.openstreetmap.org/way/44168695( fixed)

Bridge and Tunnel together

https://www.openstreetmap.org/way/301666406 ( fixed)

Delete bridge tag

https://www.openstreetmap.org/way/5659866 (fixed)
https://www.openstreetmap.org/way/102490580 (no error)

Delete bridge tag and add tunnel=culvert to the stream

https://www.openstreetmap.org/way/294686437
https://www.openstreetmap.org/way/183003857
https://www.openstreetmap.org/way/161884161
https://www.openstreetmap.org/way/51696205
https://www.openstreetmap.org/way/205889696

cc. @mapbox/peru-office I only added layer to the bridge on #to-fix:missing layer bridges minor , The label bridge was added by other users that could be a local mapper. It would not be appropriate to modify their work.

Delete bridge tag and add tunnel=yes to the highway

https://www.openstreetmap.org/way/100492951 (no error)

Use bridge=covered instead of bridge=yes

https://www.openstreetmap.org/way/195179733 (fixed)

Split and join highways based on the direction

https://www.openstreetmap.org/way/271950683 (all services around)(fixed)

Split highway

https://www.openstreetmap.org/way/361991902 (no error)
https://www.openstreetmap.org/way/295436096 (fixed)
https://www.openstreetmap.org/way/190545870 (fixed)

Wrong turn:lanes value

https://www.openstreetmap.org/way/359612958
https://www.openstreetmap.org/way/229928636 (split the way)
https://www.openstreetmap.org/way/364967170
https://www.openstreetmap.org/way/415803412
https://www.openstreetmap.org/way/427891397
https://www.openstreetmap.org/way/430390511 (fixed)

cc. @mapbox/peru-office I only fixed number of lanes on #to-fix:invalid turnlanes , the turn:lanes value was added by other users that could be a local mapper. It would not be appropriate to modify their work.

Wrong starting of turn:lanes

https://www.openstreetmap.org/way/397514357 (fixed)
https://www.openstreetmap.org/way/307512528 (no error)
https://www.openstreetmap.org/way/398059555 (fixed)
https://www.openstreetmap.org/way/398061564 (fixed)
https://www.openstreetmap.org/way/398061568 (fixed)

@maning
Copy link
Contributor

maning commented Jul 25, 2016

Thank team!

Plotting for the building must be closed

https://www.openstreetmap.org/way/23867087

Won't fix. This is part of a multipolygon.

https://www.openstreetmap.org/way/332535537

Fixed

Line up the building

https://www.openstreetmap.org/way/288656709

Won't fix. This will soon be replaced by import data. I just fixed selfintersections.

Combine the building

https://www.openstreetmap.org/way/274879945

Fixed.

Incorrect form of the building

https://www.openstreetmap.org/way/257541341

Looks good to me.

https://www.openstreetmap.org/way/430966989 - also review the building at side

Fixed.

https://www.openstreetmap.org/way/430592515

Fixed.

https://www.openstreetmap.org/way/430323349

Fixed.

https://www.openstreetmap.org/way/430773655

Fixed

The building does not match satellite imagery

https://www.openstreetmap.org/way/430553034 - also review the building at side

It matches the LACounty-2014 imagery, which we agreed to use as additional reference during import.

Separate the building

https://www.openstreetmap.org/way/430325454

Fixed.

@maanyaumashaanker
Copy link

Thank you very much for the review.

Please find the modified edits in the following changeset:
https://www.openstreetmap.org/changeset/41007443
https://www.openstreetmap.org/changeset/41007650

@planemad
Copy link
Contributor

Together buildings

Won't fix. We're planning on an automatic detection of such issues during validation osmlab/labuildings#98

https://www.openstreetmap.org/way/431118327

Fixed

@krishnanammala
Copy link
Contributor

Thanks everyone for fixing the issues 👍 Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests