-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data team peer review 7/11-7/15 #212
Comments
Crossing buildinghttps://www.openstreetmap.org/way/345524128/history Improve this buiding |
Plotting for the building must be closedhttps://www.openstreetmap.org/way/23867087 Line up the buildinghttps://www.openstreetmap.org/way/288656709 Combine the buildinghttps://www.openstreetmap.org/way/274879945 Incorrect form of the buildinghttps://www.openstreetmap.org/way/257541341 The building does not match satellite imageryhttps://www.openstreetmap.org/way/430553034 - also review the building at side Separate the building |
Remove landuse tag |
Crossing building - Change your OSM user for the import of buildingshttps://www.openstreetmap.org/way/430933346 |
Thanks for reviewing team! Delete bridge=yes and correct tunnel=building_passage, layer=-1https://www.openstreetmap.org/changeset/40909187 Delete bridge=yes and correct layerhttps://www.openstreetmap.org/changeset/40909220 Add tag highwayhttps://www.openstreetmap.org/changeset/40696770 Delete tunnel and add layer = 1 in the bridgehttps://www.openstreetmap.org/changeset/14784340 Not tunnel and bridge togetherhttps://www.openstreetmap.org/changeset/40909264 Delete tag bridge=yesDelete layerhttps://www.openstreetmap.org/way/430411172/history Delete tag bridge=yeshttps://www.openstreetmap.org/way/49165700/history Split the highwayshttps://www.openstreetmap.org/changeset/40665897 Shouldn't the highways traverse |
Thanks @mapbox/peru-office for the review!! Improve this way |
Thanks for your review team! Unclosed wayhttps://www.openstreetmap.org/changeset/40921405 Bridge tag and layer tag are incorrecthttps://www.openstreetmap.org/changeset/40921552 Missing layer taghttps://www.openstreetmap.org/changeset/40920983 Fix the bridgehttps://www.openstreetmap.org/changeset/40921022 Changed
|
Thanks for the feedback team.
https://www.openstreetmap.org/changeset/40921675
https://www.openstreetmap.org/changeset/40922117
https://www.openstreetmap.org/changeset/40922337
https://www.openstreetmap.org/changeset/40922823
https://www.openstreetmap.org/changeset/40922659
https://www.openstreetmap.org/changeset/40922705 |
According : http://wiki.openstreetmap.org/wiki/Tag:landuse%3Dresidential
According : http://wiki.openstreetmap.org/wiki/Tag:barrier%3Dfence
We should remove it. |
Thank you for the feedback @karitotp Corrected this building Improved this building |
Thank team!
Won't fix. This is part of a multipolygon. Fixed
Won't fix. This will soon be replaced by import data. I just fixed selfintersections.
Fixed.
Looks good to me.
Fixed. Fixed. Fixed. Fixed
It matches the LACounty-2014 imagery, which we agreed to use as additional reference during import.
Fixed. |
Thank you very much for the review. Please find the modified edits in the following changeset: |
Won't fix. We're planning on an automatic detection of such issues during validation osmlab/labuildings#98 Fixed |
Thanks everyone for fixing the issues 👍 Closing now. |
Last peer review ticket: #209
Mapping projects to be reviewed:
Instructions
.osm
files for last week.latest-andygol.osm
. Select any.osm
file and open the data in JOSM.3
to zoom.Cmd + F
to see only the user's edits, e.g.user:andygol
.Ctrl + H
), the changeset comment will describe what specific project the user was working on.Cmd + Shift + H
.For clarifications, discuss with the @mapbox/team-data in this ticket.
The text was updated successfully, but these errors were encountered: