Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data team peer review 7/04-7/08 #209

Closed
krishnanammala opened this issue Jul 12, 2016 · 25 comments
Closed

Data team peer review 7/04-7/08 #209

krishnanammala opened this issue Jul 12, 2016 · 25 comments
Labels
peer-review

Comments

@krishnanammala
Copy link
Contributor

krishnanammala commented Jul 12, 2016 •
edited by geochetan
Loading

Last peer review ticket: #207

Mapping projects to be reviewed:

  1. Turn Lanes Mapping
  2. Exit and Destination Mapping
  3. LA buildings import
  4. To Fix invalid turn lanes
  5. To Fix overlapping highways
  6. To Fix Islands highways
  7. To Fix unconnected highways
  8. To Fix crossing highways
  9. To Fix missing layer bridges

Instructions

  • Download .osm files for last week.
  • Extract the tar file and select any OSM file of the team member.
  • Each team member will have an .osm file of edits for the last seven days. For example: latest-andygol.osm. Select any .osm file and open the data in JOSM.
  • If you don't find any osm file of a particular team member, then it means that user has not edited during the week.
  • Examine user edits in detail. In JOSM, select a random small area edited by the user and press 3 to zoom.
  • Download the latest data in OSM as a new layer and add a filter Cmd + F to see only the user's edits, e.g. user:andygol.

andyfilter3

  • Select a way/node and load the the history (Ctrl + H), the changeset comment will describe what specific project the user was working on.
  • To get an OSM link to the object, click Cmd + Shift + H.
  • Note down any feedback for each user in this ticket or comment directly in the changeset. Use this format:
username
changeset link - issue to fix
  • @krishnanammala @chtnha or @karitotp will post the feedback in the ticket (Use Github handle because OSM name is different from Github name) and make necessary changes on the same day.
  • Close the ticket once user's have fixed their edits.

For clarifications, discuss with the @mapbox/team-data in this ticket.
@geochetan
Copy link

geochetan commented Jul 13, 2016 •
edited by krishnanammala
Loading

@Rub21 We are unable to load the osm file in JOSM for the following users. I have shared the screen shot here.

screen shot 2016-07-13 at 3 44 12 pm

If you check with the osm-history-processor, It'd be helpful.

Next actions

  • Tomorrow @krishnanammala and I will go through the edits and give feedback for the missing members.

@krishnanammala
Copy link
Contributor Author

@Andygol

Align the trunk road to imagery. Bing is not available in the area. Use Mapbox Satellite:

@krishnanammala
Copy link
Contributor Author

@Rub21

Bridges connected to a non-bridge at a junction: wiki
Road not visible in imagery:

@krishnanammala
Copy link
Contributor Author

@maanyaumashaanker

building tag is not added. Also, avoid LA building import from your normal OSM account.:
combine the buildings

@krishnanammala
Copy link
Contributor Author

@pratikyadav

There is no building in the imagery, the building should be deleted:

@krishnanammala
Copy link
Contributor Author

@dannykath

Bridge should be split:
Add bridge at railway and highway intersection:
Align the bridge

@krishnanammala
Copy link
Contributor Author

@ridixcr

Bridge doesn't exit:

@manoharuss
Copy link
Contributor

@jothirnadh

Correct the shape of these buildings:

https://www.openstreetmap.org/way/429599660/history
https://www.openstreetmap.org/way/429599459/history

Give tags to these building:

https://www.openstreetmap.org/way/429599452/history
https://www.openstreetmap.org/way/429601365/history
https://www.openstreetmap.org/way/429601366/history
https://www.openstreetmap.org/way/429602711/history

Combine these buildings:

https://www.openstreetmap.org/way/429599482/history
https://www.openstreetmap.org/way/429599793/history
https://www.openstreetmap.org/way/429603673/history
https://www.openstreetmap.org/way/429603981/history
https://www.openstreetmap.org/way/429603352/history

@Andygol
Copy link
Contributor

Andygol commented Jul 13, 2016

@krishnanammala
thank you for review 👍

@Andygol

Align the trunk road to imagery. Bing is not available in the area. Use Mapbox Satellite:

I've re-aligned this ☝️ road and some ways around

https://www.openstreetmap.org/changeset/40709263

@manoharuss
Copy link
Contributor

@piligab

Can you split these roads and remove the bridge tag from part where the road is on land

https://www.openstreetmap.org/way/245571619
https://www.openstreetmap.org/way/245571617
https://www.openstreetmap.org/way/193895310

@Rub21
Copy link
Contributor

Rub21 commented Jul 13, 2016

@chtnha : I've fixed the error on files, latest file here could you check the missing users.

@Rub21
Copy link
Contributor

Rub21 commented Jul 13, 2016

https://www.openstreetmap.org/way/425613366/history
https://www.openstreetmap.org/way/328480109/history
https://www.openstreetmap.org/way/328480110/history
https://www.openstreetmap.org/way/430401775/history
https://www.openstreetmap.org/way/430401772/history
https://www.openstreetmap.org/way/429944670/history

I've fixed the errors:

https://www.openstreetmap.org/way/429372302/history
https://www.openstreetmap.org/way/429372302/history

I use mapbox satelite.

@Rub21 Rub21 closed this as completed Jul 13, 2016
@Rub21 Rub21 reopened this Jul 13, 2016
@piligab
Copy link

piligab commented Jul 13, 2016 •
edited
Loading

@krishnanammala
Thank for you review

@ridixcr
Copy link

ridixcr commented Jul 13, 2016 •
edited
Loading

Thank for the feedback!!

@dannykath
Copy link

Thanks for your review team!

Bridge should be split:
Add bridge at railway and highway intersection:
Align the bridge

@jothirnadh
Copy link

Thanks for the review @manoharuss here are my edits

Correct the shape of these buildings:

https://www.openstreetmap.org/way/429599660/history
https://www.openstreetmap.org/way/429599764/history

Give tags to these building:

@manoharuss for buildings under relations the tags will be assigned to the relation. So no need to give them separate tags. Once you double click on the relation, you will be seeing the tags assigned to that building.
Ex:
https://www.openstreetmap.org/way/429599452/history

Combine these buildings:

https://www.openstreetmap.org/way/429599783/history
https://www.openstreetmap.org/way/429599793/history
https://www.openstreetmap.org/way/429603673/history
https://www.openstreetmap.org/way/429603517/history
https://www.openstreetmap.org/way/429602927/history

@maanyaumashaanker
Copy link

Hey @krishnanammala. Thank you very much for reviewing the edits.
I have made the necessary changes. The below mentioned changeset reflect the same.

and I will also be cautious about the User Id for the building imports.

@krishnanammala
Copy link
Contributor Author

@calfarome

Shorten this bridge based on imagery:
Move the bridge:

@krishnanammala
Copy link
Contributor Author

@RichRico

The bridge should be split:

@krishnanammala
Copy link
Contributor Author

@Yurasi

Move the bridge:

@Yurasi
Copy link

Yurasi commented Jul 14, 2016

Thanks for your review team!

Move the bridge:

@calfarome
Copy link

Thanks for the review @krishnanammala. here are my edits

Shorten this bridge based on imagery:
Move the bridge:

@RichRico
Copy link

RichRico commented Jul 18, 2016 •
edited
Loading

Thanks for the feedback @krishnanammala. here is my changeset

The bridge should be split:

https://www.openstreetmap.org/changeset/40819617

@pratikyadav
Copy link
Contributor

My corrections
https://www.openstreetmap.org/changeset/40848439

Thanks team.

@krishnanammala
Copy link
Contributor Author

Thank you all for fixing the issues 👍 . Closing now.

@karitotp karitotp mentioned this issue Jul 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
peer-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests