Disk (with UTFGrids) to mbtiles #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember you guyz saying that you don't use this tool at mapbox. And I imagine how delicate it can be to merge some code without test suites... Would that be worth to add a basic test (like bijectivity read/write) ? |
|
Absolutely, that would be great |
|
Thanks to leplatrem, we now have some tests for this code! |
|
Cool! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the possibility of making a MBTiles containing UTFGrid (with ".grid.json" extension) files from files on the disk. To check the result, I tried to upload the MBTiles produced (with TileMill and after conversion MBTiles -> files -> MBTiles) on mapbox.com.
Do I have to write something in "CHANGE.txt"? It does not seem to be used anymore.
Do I have to count the UTFGrid produced and display the result as it is made for the tiles?