Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have needle follow redirects #361

Merged
merged 4 commits into from
Apr 12, 2018
Merged

Have needle follow redirects #361

merged 4 commits into from
Apr 12, 2018

Commits on Mar 28, 2018

  1. Have needle follow redirects 

    Redirect following for binary installations was broken with the switch
to needle (in 9a9089b). This replaces the functionality.
    Allen Luce committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    7b631ed View commit details
    Browse the repository at this point in the history

  2. Use location header to detect redirects 

    This will handle things needle thinks are redirects without having to
check a bunch of status codes.
    Allen Luce committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    5c31f6c View commit details
    Browse the repository at this point in the history

  3. Test redirect functionality 

    This introduces nock as a means of mocking HTTP requests.
    Allen Luce committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    1cb7f56 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2018

  1. Handle different platform binary specs 

    So it doesn't fail on non-OSX, non-node-4 platforms.
    Allen Luce committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    b2e0d08 View commit details
    Browse the repository at this point in the history