Upgrade tar to address security vulnerability
#713
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,9 +2,9 @@ os: Visual Studio 2015 | |
|
|
||
| environment: | ||
| matrix: | ||
| - nodejs_version: 18 | ||
| - nodejs_version: 20 | ||
| - nodejs_version: 21 | ||
|
|
||
| platform: | ||
| - x64 | ||
|
|
@@ -24,6 +24,7 @@ install: | |
| - IF /I "%PLATFORM%" == "x64" CALL "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" amd64 | ||
| - IF /I "%PLATFORM%" == "x86" CALL "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x86 | ||
| - npm ci | ||
| - npm run update-crosswalk | ||
|
There was a problem hiding this comment. Great! Now set lines 5 thru 7 of - nodejs_version: 18
- nodejs_version: 20
- nodejs_version: 22to match https://nodejs.org/en/about/previous-releases#release-schedule and your tests should be green. ✅ There was a problem hiding this comment. The tests would be green because of the newer Node versions, but are you sure I should remove the older versions from the tests? There was a problem hiding this comment. Well, it did not pass for Node 20 and 21. There was a problem hiding this comment. looks like there's an explanation for that here: https://github.com/mapbox/node-pre-gyp/pull/712/files#diff-92ab9a36df5d8e9f7076f2fdec59492d1ac2d9cf27ea046767a7fc4d542ef3dcR11 |
||
| - npm test | ||
|
|
||
| build: off | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node 22 is out now